docker-users update#25520
Conversation
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
github-actions
Bot
added
the
area/desktop
docker-agent
left a comment
docker-agent
left a comment
There was a problem hiding this comment.
Assessment: 🟡 NEEDS ATTENTION
One link inconsistency found in the new WARNING callout added to windows-install.md. The faq.md callout uses the correct internal link format; the windows-install.md callout does not.
docker-agent
left a comment
docker-agent
left a comment
There was a problem hiding this comment.
Assessment: 🟡 NEEDS ATTENTION
|
|
||
| > [!WARNING] | ||
| > | ||
| > Membership in `docker-users` grants access to the Docker daemon socket, which is equivalent to granting administrative privileges on the host. Only add users who require access to Windows containers or Hyper-V VM management. For Linux containers using the WSL 2 backend, this group membership is not required. See [Protect the Docker daemon socket](/manuals/engine/security/protect-access.md) for more information. |
There was a problem hiding this comment.
[MEDIUM] Broken internal link — missing /manuals/ prefix
The link to Protect the Docker daemon socket uses the path /engine/security/protect-access/, but the canonical internal link format for this repo is /manuals/<path>.md. The companion callout added in faq.md (in this same PR) correctly uses /manuals/engine/security/protect-access.md, and other existing files (e.g. content/manuals/engine/daemon/remote-access.md) also use the /manuals/… format.
The /engine/security/… path would only work if Hugo has an alias redirect for that URL. Without one, the link will 404.
Suggested fix:
See [Protect the Docker daemon socket](/manuals/engine/security/protect-access.md) for more information.
|
|
||
| > [!WARNING] | ||
| > | ||
| > Membership in `docker-users` grants access to the Docker daemon socket, which is equivalent to granting administrative privileges on the host. Only add users who require access to Windows containers or Hyper-V VM management. For Linux containers using the WSL 2 backend, this group membership is not required. See [Protect the Docker daemon socket](/manuals/engine/security/protect-access.md) for further information. |
There was a problem hiding this comment.
[LOW] Inconsistent phrasing between companion callouts
This callout ends with "for further information", while the nearly identical callout added in windows-install.md (in this same PR) ends with "for more information". Since both callouts contain the same warning text, they should use the same closing phrase for consistency.
Suggested fix: Change "for further information" to "for more information" to match windows-install.md.
docker-agent
left a comment
docker-agent
left a comment
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
The changes add a security warning callout about docker-users group membership to two pages and a cross-reference link from the Windows install guide to the enterprise FAQ. The security content is accurate and well-placed. No vendored or generated files are touched, no pages are removed without redirect aliases, no AI-isms or markdown errors are present, and Hugo front matter is valid.
Two minor polish items noted as inline comments.
| > [!WARNING] | ||
| > | ||
| > Membership in `docker-users` grants access to the Docker daemon socket, which is equivalent to granting administrative privileges on the host. Only add users who require access to Windows containers or Hyper-V VM management. For Linux containers using the WSL 2 backend, this group membership is not required. See [Protect the Docker daemon socket](/manuals/engine/security/protect-access.md) for more information. | ||
|
|
There was a problem hiding this comment.
[LOW] Link text is a full question sentence (~17 words), exceeding the ~5-word style guide recommendation
The cross-reference link text uses the entire FAQ heading as its anchor: "Why isn't the docker-users group populated when the MSI is installed with Intune or another MDM solution?". The Docker style guide recommends link text of around five words, front-loaded with important terms, to aid scannability. A shorter alternative such as "docker-users group not populated via MDM" conveys the same meaning at a glance.
|
|
||
| The script would be responsible for ensuring the `docker-users` group exists and populating it with the correct user. | ||
|
|
||
| > [!WARNING] |
There was a problem hiding this comment.
[LOW] Callout closing phrase differs from the matching callout in windows-install.md
This callout ends with "for further information" while the identical callout added in content/manuals/desktop/setup/install/windows-install.md ends with "for more information". The two callouts are otherwise near-identical duplicates; the inconsistent phrasing is a minor polish issue. The style guide also treats trailing meta-phrases like "for more/further information" as unnecessary — the link itself is sufficient.
3 participants
Description
As per
https://docker.slack.com/archives/C02TNT09P4M/p1782232466233259
Related issues or tickets
Reviews