Skip to content

Drop support for SQLAlchemy 1.3 - #323

Merged
bgunebakan merged 28 commits into
mainfrom
bilal/303-drop-sqlalchemy-1.3
Oct 19, 2026
Merged

bgunebakan merged 28 commits into
mainfrom
bilal/303-drop-sqlalchemy-1.3

Conversation

@bgunebakan

@bgunebakan bgunebakan commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Summary of the changes / Why this is an improvement

Drops support for SQLAlchemy 1.3, and adds deprecate warning for SQLAlchemy 1.4. SQLAlchemy 1.3 has been EOL since March 2021. It has no wheels for Python versions (>=3.10).

  • Package requires sqlalchemy>=1.4,<2.2
  • Removed the 1.3 compiler (compat/core10.py) and the 1.3 helpers (compat/api13.py)
  • Added FutureWarning for SQLAlchemy 1.4, that is planned to drop support in future
  • Removed skip test for SQLAlchemy 1.3 and removed patches
  • Removed CI workflows
  • Updated docs

Checklist

@bgunebakan bgunebakan self-assigned this Oct 14, 2026
@coderabbitai

coderabbitai Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 290ea1a5-58fa-45c5-abc1-d05f9476c792

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@bgunebakan
bgunebakan added this pull request to stack #324 October 14, 2026 08:31
@bgunebakan bgunebakan changed the title Update SQLAlchemy version constraints in workflows and dependencies Drop support for SQLAlchemy 1.3 Oct 14, 2026
@github-advanced-security

Copy link
Copy Markdown

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

@bgunebakan bgunebakan added the dependencies Pull requests that update a dependency file label Oct 14, 2026
@bgunebakan
bgunebakan requested a review from florinutz October 14, 2026 10:15
Base automatically changed from bilal/303-ci-test-against-real-cratedb-versions to main October 19, 2026 09:59
@bgunebakan
bgunebakan merged commit 6c1a4ce into main Oct 19, 2026
26 checks passed
@bgunebakan
bgunebakan deleted the bilal/303-drop-sqlalchemy-1.3 branch October 19, 2026 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI: Test against real CrateDB versions, and drop SQLAlchemy 1.3/1.4

3 participants