Skip to content

Remove the sign conversions and any differentiated handling #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mborland merged 19 commits into from
Apr 30, 2026

More unused variable for clang on win

a6e44c6
Select commit
Loading
Failed to load commit list.
Merged

Remove the sign conversions and any differentiated handling #390

More unused variable for clang on win
a6e44c6
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Apr 30, 2026 in 0s

95.91% (-2.99%) compared to f5d7ca1

View this Pull Request on Codecov

95.91% (-2.99%) compared to f5d7ca1

Details

Codecov Report

❌ Patch coverage is 60.09501% with 168 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.91%. Comparing base (f5d7ca1) to head (a6e44c6).

Files with missing lines Patch % Lines
test/test_builtin_parity.cpp 29.72% 0 Missing and 130 partials ⚠️
test/test_mixed_type_sign_compare.cpp 25.00% 0 Missing and 24 partials ⚠️
test/test_mixed_type_sign_conversion.cpp 22.22% 2 Missing and 12 partials ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #390      +/-   ##
===========================================
- Coverage    98.89%   95.91%   -2.99%     
===========================================
  Files           67       68       +1     
  Lines         5636     5827     +191     
  Branches      1788     1905     +117     
===========================================
+ Hits          5574     5589      +15     
- Misses          31       34       +3     
- Partials        31      204     +173

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov