Skip to content

Remove the sign conversions and any differentiated handling#390

Merged
mborland merged 19 commits intodevelopfrom
388
Apr 30, 2026
Merged

Remove the sign conversions and any differentiated handling#390
mborland merged 19 commits intodevelopfrom
388

Conversation

@mborland
Copy link
Copy Markdown
Member

Closes: #388
Closes: #389

@mborland mborland added this to the v3.0.0 milestone Apr 29, 2026
@mborland mborland self-assigned this Apr 29, 2026
@mborland mborland added the Boost Review Feedback from the review period including pre- and post- on the ML label Apr 29, 2026
@cppalliance-bot
Copy link
Copy Markdown

cppalliance-bot commented Apr 29, 2026

An automated preview of the documentation is available at https://390.int128.prtest3.cppalliance.org/libs/int128/doc/html/index.html

If more commits are pushed to the pull request, the docs will rebuild at the same URL.

2026-04-30 15:29:05 UTC

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 30, 2026

Codecov Report

❌ Patch coverage is 60.09501% with 168 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.91%. Comparing base (f5d7ca1) to head (a6e44c6).
⚠️ Report is 20 commits behind head on develop.

Files with missing lines Patch % Lines
test/test_builtin_parity.cpp 29.72% 0 Missing and 130 partials ⚠️
test/test_mixed_type_sign_compare.cpp 25.00% 0 Missing and 24 partials ⚠️
test/test_mixed_type_sign_conversion.cpp 22.22% 2 Missing and 12 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #390      +/-   ##
===========================================
- Coverage    98.89%   95.91%   -2.99%     
===========================================
  Files           67       68       +1     
  Lines         5636     5827     +191     
  Branches      1788     1905     +117     
===========================================
+ Hits          5574     5589      +15     
- Misses          31       34       +3     
- Partials        31      204     +173     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mborland mborland merged commit 465721a into develop Apr 30, 2026
75 of 77 checks passed
@mborland mborland deleted the 388 branch April 30, 2026 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Boost Review Feedback from the review period including pre- and post- on the ML

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove differentiated handling of sign conversions Replace hard sign conversion errors with maybe warnings?

2 participants