Feature/allow empty commit

[Dranaxel]

Description

Add allow to create empty commit

Checklist

• Add test cases to all the changes you introduce
• Run ./scripts/format and ./scripts/test locally to ensure this change passes linter check and test
  • One error on create commit message seem to be here before
• Test the changes on the local machine manually
• Update the documentation for the changes
  • Not needed

Expected behavior

Allow to invoke cz and create a commit without any change in it

Additional context

Relates to #247 & #590

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (92b1e89) 98.32% compared to head (a4c9a1e) 98.33%.
Report is 401 commits behind head on master.

❗ Current head a4c9a1e differs from pull request most recent head 4f9c725. Consider uploading reports for the commit 4f9c725 to get more accurate results

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #592   +/-   ##
=======================================
  Coverage   98.32%   98.33%           
=======================================
  Files          39       39           
  Lines        1614     1618    +4     
=======================================
+ Hits         1587     1591    +4     
  Misses         27       27           

Flag	Coverage Δ
unittests	98.33% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Dranaxel]

@Lee-W Can you elaborate about what bother you in this test case ?

[Lee-W]

I'm kinda not sure whether this is correctly tested and will need sometime to figure it out. Will try to check it this week

[Dranaxel]

Hi, I think we have a misunderstanding here. When I say "Empty commit" I mean a commit with no changes in it but we still need a message inside.

[Lee-W]

@Dranaxel Thanks for correcting me. Yes, you're right. In that case, we probably should assert whether this function is called with --allow-empty. This can be done by something likeassert_called_with.

[Dranaxel]

Sorry i'm not sure about what you mean/how to use assert_called_with. Are you suggesting to assert the flag allow-empty was here when le command was launched ?

[Lee-W]

assert --allow-empty is actually passed into commitizen.git.commit when the operation above is executed

[noirbizarre]

Need rebase but I am OK with this one. I can definitely see use cases where you just want to force a commit without changes (like forcing rebuild to have updated dependencies).

Note: we might want the bump counter part for the same reason, aka. being able to force a release not containing commits eligible to changelog (aka. #723)

[bearomorphism]

Commitizen has cz commit -- --allow-empty now. Do we still need this change?

[Lee-W]

Commitizen has cz commit -- --allow-empty now. Do we still need this change?

Yep, you're right. Thanks for reminding us. Let me close it