feat(commit): add '--allow-empty' flag to commit command#1217
feat(commit): add '--allow-empty' flag to commit command#1217Lee-W merged 1 commit intocommitizen-tools:masterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1217 +/- ##
==========================================
+ Coverage 97.33% 97.58% +0.24%
==========================================
Files 42 55 +13
Lines 2104 2608 +504
==========================================
+ Hits 2048 2545 +497
- Misses 56 63 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Hi, thanks for contributing! would like to know why do we want |
|
Coverage fixed 👍. Lee-W, apart from regular usage, it's because the staging area checks fail : $ cz c --allow-empty
-Invalid commitizen arguments were found: `--allow-empty`. Please use -- separator for extra git args
$ cz c -- --allow-empty
-No files added to staging!
# =======================
$ pipx uninstall commitizen; pipx install .
uninstalled commitizen! ✨ 🌟 ✨
installed package commitizen 3.29.0, installed using Python 3.12.3
These apps are now globally available
- cz
- git-cz
done! ✨ 🌟 ✨
# =======================
$ cz c --allow-empty
? Select the type of change you are committing feat: A new feature. Correlates with MINOR in SemVer
? What is the scope of this change? (class or file name): (press [enter] to skip)
test
? Write a short and imperative summary of the code changes: (lower case and no period)
test
? Provide additional contextual information about the code changes: (press [enter] to skip)
? Is this a BREAKING CHANGE? Correlates with MAJOR in SemVer No
? Footer. Information about Breaking Changes and reference issues that this commit closes: (press [enter] to skip)
feat(test): test
[master 6b9618c5] feat(test): test
+Commit successful! |
|
As discussed, I redid it all into Tested locally with |
217e255 to
556ae98
Compare
|
Rebased, ready to roll after 1206 👍 |
|
1206 merged 🙌 |
Signed-off-by: Adrian DC <radian.dc@gmail.com>
556ae98 to
a442d70
Compare
|
👍 |
Description
feat(commit): add '--allow-empty' flag to commit command
Checklist
./scripts/formatand./scripts/testlocally to ensure this change passes linter check and testExpected behavior
Allow to invoke cz and create a commit without any change in it
Steps to Test This Pull Request
Additional context