fix(onboarding): use brand mark in recovery cards - #115
Merged
Conversation
Render the Cheatcode mark in onboarding retry and load-error states. Generalize the recovery-card visual slot for Lucide and branded visuals.
9 tasks
iamjr15
added a commit
that referenced
this pull request
Aug 2, 2026
## Summary - replace the two remaining generic Lucide `Sparkles` icons in skills-catalog recovery cards with `CheatcodeMark` - remove the now-unused `Sparkles` exports from the web icon barrels - preserve the custom orange onboarding `Sparkle` artwork and vendored Office schema value ## Context Follow-up to #115 from a direct codebase audit; no Linear issue or plan document was created for this focused cleanup. ## Decisions Made | Decision | Choice | Alternatives considered | Reasoning | |---|---|---|---| | Skills recovery visual | Reuse `CheatcodeMark` through the existing `RecoveryCard` component slot | Keep the generic icon or add a brand-specific mode | Matches onboarding recovery states without duplicating surfaces or adding boolean API modes | | Remaining sparkle artwork | Preserve the custom onboarding SVGs | Replace every star-shaped visual | Those SVGs are intentional Paper design-system artwork, not generic Lucide placeholders | | Icon barrel | Remove `Sparkles` entirely | Leave an unused export | Prevents accidental reuse and is verified by the dead-code and repository search checks | ## How to Review 1. Review `integration-skills-grid.tsx` for both recovery-state callers. 2. Confirm `icons.ts` and `index.ts` only remove the unused Lucide export. ## Verification - [x] repository search finds no `Sparkles` or `lucide-sparkles` references - [x] `pnpm lint` - [x] `pnpm typecheck` - [x] `pnpm turbo build --force` - [x] `pnpm deadcode` - [x] `pnpm architecture:check` - [x] `pnpm turbo skills:build` - [x] local Next.js process started and the Clerk sign-in route returned HTTP 200 - [ ] protected `/skills` visual state was not entered because the browser's autofilled development account is not registered in this Clerk instance; no auth data was created or changed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Context
Direct user-reported onboarding UI defect; no Linear issue or plan document was created for this focused fix.
Decisions Made
classNameandaria-hiddenstrokeWidthpropHow to Review
recovery-card.tsxfor the generalized visual contract.onboarding-flow.tsxfor both branded recovery-state call sites.Verification
pnpm lintpnpm typecheckpnpm turbo build --forcepnpm deadcodepnpm architecture:checkpnpm turbo skills:buildSetup needs one more stepCheatcodeMarkpresent,lucide-sparklesabsent, andFinish setupenabled