Skip to content

Commit b947a51

Browse files
authored
fix(skills): use brand mark in recovery cards (#116)
## Summary - replace the two remaining generic Lucide `Sparkles` icons in skills-catalog recovery cards with `CheatcodeMark` - remove the now-unused `Sparkles` exports from the web icon barrels - preserve the custom orange onboarding `Sparkle` artwork and vendored Office schema value ## Context Follow-up to #115 from a direct codebase audit; no Linear issue or plan document was created for this focused cleanup. ## Decisions Made | Decision | Choice | Alternatives considered | Reasoning | |---|---|---|---| | Skills recovery visual | Reuse `CheatcodeMark` through the existing `RecoveryCard` component slot | Keep the generic icon or add a brand-specific mode | Matches onboarding recovery states without duplicating surfaces or adding boolean API modes | | Remaining sparkle artwork | Preserve the custom onboarding SVGs | Replace every star-shaped visual | Those SVGs are intentional Paper design-system artwork, not generic Lucide placeholders | | Icon barrel | Remove `Sparkles` entirely | Leave an unused export | Prevents accidental reuse and is verified by the dead-code and repository search checks | ## How to Review 1. Review `integration-skills-grid.tsx` for both recovery-state callers. 2. Confirm `icons.ts` and `index.ts` only remove the unused Lucide export. ## Verification - [x] repository search finds no `Sparkles` or `lucide-sparkles` references - [x] `pnpm lint` - [x] `pnpm typecheck` - [x] `pnpm turbo build --force` - [x] `pnpm deadcode` - [x] `pnpm architecture:check` - [x] `pnpm turbo skills:build` - [x] local Next.js process started and the Clerk sign-in route returned HTTP 200 - [ ] protected `/skills` visual state was not entered because the browser's autofilled development account is not registered in this Clerk instance; no auth data was created or changed
1 parent bb71f72 commit b947a51

3 files changed

Lines changed: 4 additions & 5 deletions

File tree

apps/web/src/components/skills/integration-skills-grid.tsx

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,9 @@ import type { ToolkitCatalogEntry, UserSkill } from "@cheatcode/types/api";
33
import { IntegrationBrandLogo } from "@/components/skills/integration-brand-logo";
44
import type { IntegrationDrawerHandlers } from "@/components/skills/integration-skill-drawer";
55
import { UserSkillCard, type UserSkillsCatalog } from "@/components/skills/user-skills-section";
6-
import { Loader2, Sparkles } from "@/components/ui";
6+
import { Loader2 } from "@/components/ui";
77
import { CheatcodeLoader } from "@/components/ui/cheatcode-loader";
8+
import { CheatcodeMark } from "@/components/ui/cheatcode-mark";
89
import { RecoveryCard } from "@/components/ui/recovery-card";
910
import { cn } from "@/lib/ui/cn";
1011

@@ -80,7 +81,7 @@ function InlineToolsError({ isRetrying, onRetry }: { isRetrying: boolean; onRetr
8081
pendingLabel: "Loading skills…",
8182
}}
8283
description="Cheatcode couldn't reach the skills catalog. Check your connection and try again."
83-
icon={Sparkles}
84+
icon={CheatcodeMark}
8485
size="compact"
8586
title="Skills couldn't load"
8687
/>
@@ -156,7 +157,7 @@ function ToolsError({ isRetrying, onRetry }: { isRetrying: boolean; onRetry: ()
156157
pendingLabel: "Loading skills…",
157158
}}
158159
description="Cheatcode couldn't reach the skills catalog. Check your connection and try again."
159-
icon={Sparkles}
160+
icon={CheatcodeMark}
160161
size="compact"
161162
title="Skills couldn't load"
162163
/>

apps/web/src/components/ui/icons.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@ export {
4444
Search,
4545
SlidersHorizontal,
4646
Smartphone,
47-
Sparkles,
4847
Square,
4948
SquareAsterisk,
5049
Star,

apps/web/src/components/ui/index.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,6 @@ export {
4545
Search,
4646
SlidersHorizontal,
4747
Smartphone,
48-
Sparkles,
4948
Square,
5049
SquareAsterisk,
5150
Star,

0 commit comments

Comments
 (0)