Commit b947a51
authored
fix(skills): use brand mark in recovery cards (#116)
## Summary
- replace the two remaining generic Lucide `Sparkles` icons in
skills-catalog recovery cards with `CheatcodeMark`
- remove the now-unused `Sparkles` exports from the web icon barrels
- preserve the custom orange onboarding `Sparkle` artwork and vendored
Office schema value
## Context
Follow-up to #115 from a direct codebase audit; no Linear issue or plan
document was created for this focused cleanup.
## Decisions Made
| Decision | Choice | Alternatives considered | Reasoning |
|---|---|---|---|
| Skills recovery visual | Reuse `CheatcodeMark` through the existing
`RecoveryCard` component slot | Keep the generic icon or add a
brand-specific mode | Matches onboarding recovery states without
duplicating surfaces or adding boolean API modes |
| Remaining sparkle artwork | Preserve the custom onboarding SVGs |
Replace every star-shaped visual | Those SVGs are intentional Paper
design-system artwork, not generic Lucide placeholders |
| Icon barrel | Remove `Sparkles` entirely | Leave an unused export |
Prevents accidental reuse and is verified by the dead-code and
repository search checks |
## How to Review
1. Review `integration-skills-grid.tsx` for both recovery-state callers.
2. Confirm `icons.ts` and `index.ts` only remove the unused Lucide
export.
## Verification
- [x] repository search finds no `Sparkles` or `lucide-sparkles`
references
- [x] `pnpm lint`
- [x] `pnpm typecheck`
- [x] `pnpm turbo build --force`
- [x] `pnpm deadcode`
- [x] `pnpm architecture:check`
- [x] `pnpm turbo skills:build`
- [x] local Next.js process started and the Clerk sign-in route returned
HTTP 200
- [ ] protected `/skills` visual state was not entered because the
browser's autofilled development account is not registered in this Clerk
instance; no auth data was created or changed1 parent bb71f72 commit b947a51
3 files changed
Lines changed: 4 additions & 5 deletions
Lines changed: 4 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
| 6 | + | |
7 | 7 | | |
| 8 | + | |
8 | 9 | | |
9 | 10 | | |
10 | 11 | | |
| |||
80 | 81 | | |
81 | 82 | | |
82 | 83 | | |
83 | | - | |
| 84 | + | |
84 | 85 | | |
85 | 86 | | |
86 | 87 | | |
| |||
156 | 157 | | |
157 | 158 | | |
158 | 159 | | |
159 | | - | |
| 160 | + | |
160 | 161 | | |
161 | 162 | | |
162 | 163 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
44 | 44 | | |
45 | 45 | | |
46 | 46 | | |
47 | | - | |
48 | 47 | | |
49 | 48 | | |
50 | 49 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
45 | 45 | | |
46 | 46 | | |
47 | 47 | | |
48 | | - | |
49 | 48 | | |
50 | 49 | | |
51 | 50 | | |
| |||
0 commit comments