Repository navigation
controller: ignore deleted ClientProfiles (backport #646) - #658
Merged
Merged
Conversation
When a ClientProfile is deleted, reconcilePhases removes the cleanup finalizer and the API server deletes the object. reconcile() then updates the status of the deleted object, gets NotFound and returns it, so the request is requeued. Every retry fails again when loading the ClientProfile, which also returns NotFound, and the key stays in the queue at the maximum backoff until the operator restarts. Return early when the ClientProfile is not found, as the ClientProfileReplication controller does, and ignore NotFound from the status update. Signed-off-by: Vemula-Rohith <vemularohith93@gmail.com> (cherry picked from commit 9323376)
3 of 6 tasks
Author
|
This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe what this PR does
Stop the ClientProfile controller from requeuing deleted ClientProfiles.
reconcile()and return nil if it is notfound, as the ClientProfileReplication controller does. A missing
CephConnection is still an error.
lets the ClientProfile be deleted before the update runs.
Two unit tests cover reconciling a missing ClientProfile and deleting
one with no referencing ClientProfileReplication. Each fails without
the matching change.
Is there anything that requires special attention
No API or behaviour change for existing ClientProfiles.
Related issues
Fixes: #645
Checklist:
guidelines in the developer
guide.
Request
notes
updated with breaking and/or notable changes for the next major release.
This is an automatic backport of pull request #646 done by [Mergify](https://mergify.com).