Repository navigation
controller: ignore deleted ClientProfiles - #646
Conversation
|
This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again. |
|
@Mergifyio rebase |
❌ This pull request comes from a fork and cannot be rebasedDetailsGitHub refuses an OAuth token on its rebase API for a fork, so rebasing one means impersonating a GitHub user to force-push the contributor's branch. Mergify does not do that. Use the |
|
@Vemula-Rohith can you please rebase the PR |
Yeah sure. |
When a ClientProfile is deleted, reconcilePhases removes the cleanup finalizer and the API server deletes the object. reconcile() then updates the status of the deleted object, gets NotFound and returns it, so the request is requeued. Every retry fails again when loading the ClientProfile, which also returns NotFound, and the key stays in the queue at the maximum backoff until the operator restarts. Return early when the ClientProfile is not found, as the ClientProfileReplication controller does, and ignore NotFound from the status update. Signed-off-by: Vemula-Rohith <vemularohith93@gmail.com>
3baef1c to
9323376
Compare
Describe what this PR does
Stop the ClientProfile controller from requeuing deleted ClientProfiles.
reconcile()and return nil if it is notfound, as the ClientProfileReplication controller does. A missing
CephConnection is still an error.
lets the ClientProfile be deleted before the update runs.
Two unit tests cover reconciling a missing ClientProfile and deleting
one with no referencing ClientProfileReplication. Each fails without
the matching change.
Is there anything that requires special attention
No API or behaviour change for existing ClientProfiles.
Related issues
Fixes: #645
Checklist:
guidelines in the developer
guide.
Request
notes
updated with breaking and/or notable changes for the next major release.