Repository navigation
YARN-12049. Shut down the thread pool in FederationRMAdminInterceptor - #8887
Open
luoyuan3471 wants to merge 1 commit into
Open
luoyuan3471 wants to merge 1 commit into
luoyuan3471 wants to merge 1 commit into
Conversation
|
🎊 +1 overall
This message was automatically generated. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
FederationRMAdminInterceptorcreates a per-user thread pool but inherits ashutdown()method that only delegates to the next interceptor. Its ownexecutor is never shut down, so idle worker threads can remain alive when
core thread timeout is disabled.
Solution
shutdown()to shut down the executor before calling the parent method.Validation
TestFederationRMAdminInterceptor: 38 tests, 0 failures, 0 errors, 0 skipped.git diff --checkverified.Related Jira
YARN-12049