Repository navigation
YARN-12049. Close Router RMAdmin interceptor pipelines and thread pools on shutdown - #8884
Closed
luoyuan3471 wants to merge 1 commit into
Closed
luoyuan3471 wants to merge 1 commit into
luoyuan3471 wants to merge 1 commit into
Conversation
luoyuan3471
marked this pull request as draft
October 29, 2026 07:51
|
🎊 +1 overall
This message was automatically generated. |
Contributor
Author
|
Superseded by #8887, which narrows YARN-12049 to shutting down the FederationRMAdminInterceptor thread pool and its regression tests. The broader pipeline lifecycle changes are not included in the replacement PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
FederationRMAdminInterceptorcreates a per-user thread pool but does not shutit down.
RouterRMAdminServiceclears cached interceptor pipelines on stopwithout closing them, and failed pipeline initialization can leave an
already-created executor open. With core thread timeout disabled, used worker
threads can remain alive after the owning pipeline should have been shut down.
Solution
FederationRMAdminInterceptor, including safe shutdown before initialization.close()method and close cached pipelines explicitly on service stop.Validation
TestRouterRMAdminService: 8 tests, 0 failures, 0 errors, 0 skipped.TestFederationRMAdminInterceptor: 38 tests, 0 failures, 0 errors, 0 skipped.git diff --checkverified.Related Jira
YARN-12049