Repository navigation
Update NuGet packages and pin patched System.Security.Cryptography.Pkcs - #1752
Open
angularsen wants to merge 1 commit into
Open
angularsen wants to merge 1 commit into
angularsen wants to merge 1 commit into
Conversation
CodeGen restore failed with NU1903 (warnings as errors) because NuGet.Protocol pulls in System.Security.Cryptography.Pkcs 8.0.1, which has known vulnerabilities (GHSA-846f-f764-76mx, GHSA-2fmv-rv2c-59x7). NuGet.Protocol 7.9.0 still depends on 8.0.1, so pin Pkcs 10.0.14 directly. Also bump packages to latest stable: - Microsoft.NET.Test.Sdk 18.11.0 - xunit.runner.visualstudio 4.0.1 - MinVer 8.0.0 - NuGet.Protocol 7.9.0 - Serilog 4.4.0 - System.Text.Json 10.0.14 - System.Collections.Immutable 10.0.14 - System.Reflection.Metadata 10.0.14 (Samples) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1752 +/- ##
========================================
- Coverage 98% 97% -2%
========================================
Files 515 238 -277
Lines 24077 18498 -5579
========================================
- Hits 23677 18005 -5672
- Misses 400 493 +93
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes CI restore failure seen in #1751 (and on master):
Changes
System.Security.Cryptography.Pkcs10.0.14 in CodeGen. It comes in transitively viaNuGet.Protocol, and even 7.9.0 still depends on 8.0.1. Fixes GHSA-846f-f764-76mx and GHSA-2fmv-rv2c-59x7.MinVer 8's only breaking change rejects
MinVerDefaultPreReleasePhase, which is not used here.Intentionally not updated
Microsoft.CodeAnalysis.CSharp4.14.0 (Modular): the Roslyn version sets the minimum compiler version for generator consumers.System.Text.Jsonand related build-only versions inUnitsNet.Modular/Directory.Packages.props: they mirror STJ's netstandard2.0 dependency floor.Verified locally
UnitsNet.slnx: build and all tests pass (net48, net8, net9, net10).UnitsNet.Modular.slnx(Platform=ProjectReferences, Release): build and 116 tests pass.dotnet list package --vulnerable: no findings.🤖 Generated with Claude Code