Skip to content

Added ThermalConductance quantity - #1753

Open
gdeepak02 wants to merge 1 commit into
angularsen:masterfrom
gdeepak02:dgarg/AddedThermalConductance
Open

gdeepak02 wants to merge 1 commit into
angularsen:masterfrom
gdeepak02:dgarg/AddedThermalConductance

Conversation

@gdeepak02

Copy link
Copy Markdown

No description provided.

@gdeepak02

gdeepak02 commented Nov 6, 2026 •

Copy link
Copy Markdown
Author

This will need the previous pull request to go in first to sort out build issues

#1752

@gdeepak02 gdeepak02 left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had dependencies updated locally (from this PR) to be able to build and run tests. All tests passed fine for me locally.

@tmilnthorp

Copy link
Copy Markdown
Collaborator

Looks good overall. A few things:

  1. Could you add the reciprocal relation to ThermalResistance in UnitRelations.json, like the other reciprocal pairs (e.g. ElectricResistivity/ElectricConductivity)?
    "1 = ThermalConductance.WattPerKelvin * ThermalResistance.KelvinPerWatt",
    
  2. Typo in XmlDocSummary: "temperature difference.. It is" has a double period.
  3. Optional: Btu/(h·°F) is how HVAC UA values are usually quoted, and a Kilo prefix (kW/K) would match the siblings like HeatTransferCoefficient.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants