chore: update openhound github collector reference docs - #377
chore: update openhound github collector reference docs#377jeff-matthews wants to merge 1 commit into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
Will take a look before the end of the week |
|
It looks like several node and edge kinds in the schema do not have corresponding description files in the OpenHound repository. Also, some documented edge kinds no longer exist in the schema. Unless those edges are expected to be added to the schema, I assume we can delete their documentation. @jaredcatkinson, are you planning to add descriptions for the undocumented node and edge kinds? There is also an issue with the documentation-generation script / OpenHound repositories causing metadata for nodes and edges to be missing. Before the OH repositories were released, they included a @d3vzer0, it looks like the Edges
Nodes
We do not need to store inbound and outbound edges for nodes because those can be derived from the edge definitions, avoiding redundant data. |
|
I fixed the script and pushed the changes here: https://github.com/SpecterOps/og-docs-automation/ It now includes node and edge metadata by using the OpenHound command I also opened a PR in the OpenHound GitHub repo that updates the submodule and fixes a few OpenHound modules that caused documentation generation to fail: SpecterOps/openhound-github#51 Once that PR is merged and @jaredcatkinson has added the missing descriptions, we can generate the BloodHound docs with: pwsh docs/og-docs-automation/scripts/Render-Docs.ps1 -Mode Official |
|
Thanks @JonasBK! |
|
SpecterOps/openhound-github#51 has been merged. I honestly don't recall if I added all of the documentation for the node and edge types. I know I worked on some documentation but that may have been for snowflake. I can take another look here in a bit. |
|
Closing this PR as outdated, but I'll create a new one when we're ready. |
|
Thanks for all your help @JonasBK & @jaredcatkinson! See #428 for the GitHub collector reference refresh. |
Summary
This is my first attempt at running the docs automation for the openhound-github collector repo.
I'm not sure if all of these changes are expected. It looks like the new docs have stripped out some mermaid diagrams and other info, but I'm not sure if that's expected. It certainly looks like the docs have been out of date since before the latest changes that prompted this PR: SpecterOps/openhound-github#22.
Here's a summary from the script I ran locally:
See terminal output for details:
github-collector-doc-gen.txt
Note
The docs automation tooling failed on my first attempt. I created the following proposed fix in the upstream repo: SpecterOps/og-docs-automation#2.
Related to #376