Repository navigation
[params 13/13] rj_vision_receiver: remove dead interface and hz params - #2612
Open
yuvrajdhadwal wants to merge 2 commits into
Open
yuvrajdhadwal wants to merge 2 commits into
yuvrajdhadwal wants to merge 2 commits into
Conversation
This was referenced Oct 12, 2026
yuvrajdhadwal
force-pushed
the
params/13-vision-receiver-cleanup
branch
from
October 12, 2026 00:47
248b11f to
7f9ee86
Compare
yuvrajdhadwal
added this pull request to stack #2598
October 12, 2026 01:44
yuvrajdhadwal
force-pushed
the
params/13-vision-receiver-cleanup
branch
from
October 12, 2026 02:00
7f9ee86 to
0c73cbd
Compare
yuvrajdhadwal
changed the title
yuvrajdhadwal
marked this pull request as ready for review
October 12, 2026 14:45
jvogt23
force-pushed
the
params/13-vision-receiver-cleanup
branch
from
October 14, 2026 01:23
0c73cbd to
b07fbd9
Compare
jvogt23
force-pushed
the
params/13-vision-receiver-cleanup
branch
from
October 14, 2026 01:38
b07fbd9 to
b66f2f9
Compare
jvogt23
force-pushed
the
params/13-vision-receiver-cleanup
branch
from
October 18, 2026 23:21
b66f2f9 to
a69aabb
Compare
jvogt23
force-pushed
the
params/13-vision-receiver-cleanup
branch
from
October 19, 2026 00:08
a69aabb to
02ad20f
Compare
jvogt23
force-pushed
the
params/13-vision-receiver-cleanup
branch
from
October 19, 2026 00:20
02ad20f to
b62d9cf
Compare
jvogt23
force-pushed
the
params/13-vision-receiver-cleanup
branch
from
October 19, 2026 00:36
b62d9cf to
fd55907
Compare
jvogt23
force-pushed
the
params/13-vision-receiver-cleanup
branch
2 times, most recently
from
October 19, 2026 01:17
0c4eb5c to
385738b
Compare
jvogt23
force-pushed
the
params/13-vision-receiver-cleanup
branch
from
October 19, 2026 01:34
385738b to
c7de2f8
Compare
jvogt23
force-pushed
the
params/13-vision-receiver-cleanup
branch
from
October 19, 2026 01:50
c7de2f8 to
8fe75c7
Compare
jvogt23
force-pushed
the
params/13-vision-receiver-cleanup
branch
2 times, most recently
from
October 21, 2026 03:33
53b3b9f to
14e5ed0
Compare
The node read a param called "interface", but the YAML key was vision_interface, so it was always empty, and set_port ignored it anyway. Removes the read, the member, the set_port argument and the YAML entries. Also removes vision_receiver.hz, which nothing reads. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
jvogt23
force-pushed
the
params/13-vision-receiver-cleanup
branch
from
October 21, 2026 04:01
14e5ed0 to
8bbc126
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes dead params from
rj_vision_receiver.interface: the node read a param called"interface", but the YAML key wasvision_interface, so the value was always an empty string.hz: in both YAMLs, but nothing reads it. Removed.No behavior change.