Repository navigation
[params 10/13] rj_vision_filter: remove rj_param_utils - #2602
Open
yuvrajdhadwal wants to merge 5 commits into
Open
yuvrajdhadwal wants to merge 5 commits into
yuvrajdhadwal wants to merge 5 commits into
Conversation
This was referenced Oct 12, 2026
yuvrajdhadwal
changed the title
yuvrajdhadwal
force-pushed
the
params/10-vision-filter
branch
from
October 12, 2026 00:30
4f59fcc to
02d42ed
Compare
yuvrajdhadwal
changed the title
yuvrajdhadwal
changed the title
yuvrajdhadwal
added this pull request to stack #2598
October 12, 2026 01:44
yuvrajdhadwal
force-pushed
the
params/10-vision-filter
branch
from
October 12, 2026 02:00
02d42ed to
7e7be35
Compare
yuvrajdhadwal
marked this pull request as ready for review
October 12, 2026 14:44
jvogt23
force-pushed
the
params/10-vision-filter
branch
2 times, most recently
from
October 14, 2026 01:23
17f5e85 to
6b27938
Compare
jvogt23
force-pushed
the
params/10-vision-filter
branch
2 times, most recently
from
October 18, 2026 23:21
f433f92 to
bafe40b
Compare
jvogt23
force-pushed
the
params/10-vision-filter
branch
2 times, most recently
from
October 19, 2026 00:20
724fbce to
dab10b3
Compare
jvogt23
force-pushed
the
params/10-vision-filter
branch
2 times, most recently
from
October 19, 2026 01:34
11e66e6 to
cb3b997
Compare
jvogt23
force-pushed
the
params/10-vision-filter
branch
from
October 19, 2026 01:50
cb3b997 to
b97c204
Compare
shourikb
reviewed
Oct 21, 2026
| _____ | ||
| / \ | ||
| | Robot | | ||
| \_____/ |
shourikb
reviewed
Oct 21, 2026
| R | ||
| _____ | ||
| B | ||
| /|\ |
shourikb
reviewed
Oct 21, 2026
| df*45 - / \ | ||
| / \ | ||
| / \ | ||
| 0 - / \ |
shourikb
approved these changes
Oct 21, 2026
shourikb
left a comment
shourikb
left a comment
Contributor
There was a problem hiding this comment.
LGTM but i also wrote it
jvogt23
force-pushed
the
params/10-vision-filter
branch
from
October 21, 2026 03:06
b97c204 to
de2bd66
Compare
…rams From #2555. Replaces the vision filter DEFINE macros and vision_params with a VisionFilterParams struct that the VisionFilter node reads once at startup and shares as shared_ptr<const> with the camera, Kalman filters, kick detectors, bounce logic and world objects. Unit tests pass params in. Rebased onto main (team color subscription, rj_constants and rj_topic_utils removal). Removes params nothing reads: publish_hz, kick.detector.slow_robot_dist_filter_cutoff and the two vision_filter.bounce.*_lin_dampen values. Co-Authored-By: Yuvraj Dhadwal <ydhadwal3@gatech.edu> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
jvogt23
force-pushed
the
params/10-vision-filter
branch
from
October 21, 2026 04:01
de2bd66 to
cdeda54
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes
rj_param_utilsfromrj_vision_filter.declare_required_param(no defaults, no auto-declare). The ~250 lines of setters and the live-update callback are gone, since we only change params by editing the YAML.publish_hz,kick.detector.slow_robot_dist_filter_cutoffand the twovision_filter.bounce.*_lin_dampenvalues (the TODOs from Removing RJ param utils from many packages (rj_joystick, rj_vision_filter, rj_referee, rj_strategy, rj_vision_receiver) #2555).