promote to main (1/4): text/vector search window scan (fork #59) - #94
Merged
Merged
Conversation
…category node (port of fork #59) Ports trentleslie/biomapper2#59 to the org. kestrel-text-search and kestrel-vector-search hardcoded limit=1 and committed/refused on rank 1 alone; Kestrel's category_filter is advisory, so an off-category row (e.g. CHV:0000005585 "glutamate") could outrank the intended ChEBI node and the annotator returned None. Raise the window to HYBRID_SEARCH_LIMIT and take the first on-category candidate; guard the None term_results a cache-miss can produce. Opt-in change — text/vector are not in the default annotator set, so no default-pipeline behavior changes. 10 tests (network monkeypatched). Reviewed 5/5 on the fork.
This was referenced Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked promotion dev→main, 1 of 4 (mirroring the org promote PRs #90–93). Merge in order; each is the validated code already on org
dev.This PR (#59 port)
Kestrel text/vector search scans the ranked window for the first on-category candidate instead of committing/refusing on rank-1 alone (restores commits the old
limit=1path dropped; the category guard still refuses when nothing in the window is on-category).Series
All four are already merged + validated on org
dev(this is dev→main). Nostudies/. Org CIgateruns on each. No RefMet freeze is configured in prod — the freeze consumer code is inert unlessREFMET_SNAPSHOT_PATHis set.🤖 Generated with Claude Code