Skip to content

promote to main (2/4): structure-guided re-resolution of conflated commits (fork #60) - #95

Merged
trentleslie merged 2 commits into
mainfrom
promote-main-2-reresolution
Sep 9, 2026
Merged

trentleslie merged 2 commits into
mainfrom
promote-main-2-reresolution

Conversation

@trentleslie

Copy link
Copy Markdown
Collaborator

Stacked promotion dev→main, 2 of 4. #94 (#59) merged; this is #60 on top.

This PR (#60 port)

Structure-guided re-resolution: when a committed KG node's structure disagrees with the query's INDEPENDENT structure, disambiguate to the correct distinct KG candidate; plus the lipid independent-structure resolver. Benchmark-gated; part of the validated determinism/re-resolution program already on org dev.

Series

  1. Handle accidental double colons in input curies #59 text/vector window ✅ merged (promote to main (1/4): text/vector search window scan (fork #59) #94)
  2. Dockerize Biomapper2 #60 structure-guided re-resolution ← this PR
  3. Implement retry loop for API startup wait #64/PR: Return equivalent IDs from KG nodes - Feat/equivalent ids #67/PR: feat: Dynamic entity types and vocabulary presets from Kestrel #68/feat: HGNC human-preference re-ranking for gene/protein resolution #69/feat: gene/protein resolution — HGNC human-preference + curated gene-symbol fallback (dev → main) #70 — determinism stack
  4. feat: curated gene-symbol fallback resolver for drug-conflated human genes #71/feat: canonical-namespace preference + gene gold-set fix (unblocks release CI) #72 — fallback toggle + candidate_limit

dev→main; no studies/; org CI gate runs. No RefMet freeze in prod (consumer code inert unless configured).

🤖 Generated with Claude Code

trentleslie and others added 2 commits August 31, 2026 20:18
…r-window

fix(annotators): text/vector search scan the window for the first on-category node (port of fork #59)
…s + lipid independent-structure source (port of fork #60)

Port of trentleslie/biomapper2 PR #60 (merged to fork dev 2026-09-01) to Phenome-Health.
src/ + tests only — the studies/external_benchmarks benchmark harness (fork #61) stays off-org.

Applied as a 3-way port onto org dev; verified green on the org base: pyright 0 errors, ruff clean,
776 passed / 227 skipped. Reviewer note: org dev has diverged resolver work (#75/#77/#82/#83
source-weighting / URL-resolver / InChIKey-blocks) — the port merged cleanly and the full suite passes,
but confirm the re-resolution logic composes as intended with those. This promotion is the prerequisite
for the D2 RefMet-bridge re-resolution work.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@trentleslie
trentleslie merged commit b3616e7 into main Sep 9, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant