Deprecate no-op queue peek batch size (MaxRecordsToPeek / peekBatchSize)#1755
Merged
Conversation
ramonsmits
force-pushed
the
deprecate-peek-batch-size
branch
from
ab7aa42 to
b5b4ae0
Compare
The peek batch size has no effect: the peek query was changed to a RowVersion/seq range estimate, and the receive loop is bounded by the configured message processing concurrency and self-terminates on the first empty receive, so a peek batch bound is unnecessary. It has had no effect in the SQL Server transport since 6.2 (#631); the PostgreSQL transport (introduced in 9.0) has never used it. - Obsolete QueuePeekerOptions.MaxRecordsToPeek via [ObsoleteMetadata] + [Obsolete] (compile-time warning now, error from version 10, removed in 11), for SQL Server + PostgreSQL - Log a runtime warning when the property (or the legacy QueuePeekerOptions peekBatchSize argument) is set - Suppress the obsolete warning at the internal legacy-API assignment - Drop the unit test assertions that depended on the no-op value; update API approvals Resolves #1754
ramonsmits
force-pushed
the
deprecate-peek-batch-size
branch
from
b5b4ae0 to
a9ed8fc
Compare
mauroservienti
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1754.
Marks
MaxRecordsToPeek(and the legacyQueuePeekerOptionspeekBatchSizeargument)[PreObsolete]and logs a warning when set, stating the API has no effect. Applies to the SQL Server and PostgreSQL transports.