📝 Legacy docs review: SQL/PostgreSQL transport design + peek batch size deprecation#8379
Merged
Merged
Conversation
- Update reviewed date - Fix grammar in concurrency partial: "greater then" → "greater than", "there is has been" → "there have been", align "receive tasks" terminology
- RowVersion index is non-clustered on a heap, not clustered (since 6.0.1) - Peek estimates pending count via RowVersion range, not a select count query (since 6.1.1) - Remove non-functional peek batch size config: MaxRecordsToPeek is a no-op in the SQL Server transport (assigned but never read; API is [PreObsolete]). Removes the doc section and the orphaned snippet from SqlTransport_6/7/8/9 - Clarify that a sub-100ms peek delay is rejected, not merely discouraged
mauroservienti
approved these changes
Jun 29, 2026
- PostgreSQL design page: remove the no-op peek batch size config section (parallel to SQL); align receive-tasks wording and the rejected sub-100ms delay; bump reviewed date. Remove the orphaned postgresql-queue-peeker-config-batch-size snippet from PostgreSqlTransport_8/9 - sqlserver-9to10 upgrade guide: document that the queue peek batch size (MaxRecordsToPeek / peekBatchSize) has no effect, is deprecated, and should be removed - SQL design page: cross-link the non-clustered index note to the existing non-clustered index upgrade guide
ramonsmits
changed the title
Warning in the next Version 9 minor; obsolete compilation error in Version 10.
In Version 9 it produces both a compile-time warning and a runtime log warning; in Version 10 it becomes a compilation error.
mauroservienti
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Legacy documentation review of SQL Transport Design, extended to cover the PostgreSQL transport and the related upgrade guide as the docs side of the
MaxRecordsToPeek/peekBatchSizedeprecation (Particular/NServiceBus.SqlServer#1754).SQL design page
revieweddate; grammar fixes in the concurrency partial.select countquery (since 6.1.1).SqlTransport_6/7/8/9snippets (MaxRecordsToPeekis a no-op).PostgreSQL design page (parity)
PostgreSqlTransport_8/9snippets; aligned the receive-tasks wording and the rejected sub-100ms delay; bumpedreviewed.Upgrade guide
sqlserver-9to10: documented that the queue peek batch size (MaxRecordsToPeek/peekBatchSize) has no effect, is deprecated, and should be removed.Verification
docstool test --no-version-checkpasses; affected snippet projects compile.Pairs with code deprecation: