Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions drivers/teldrive/driver.go
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,12 @@ func (d *Teldrive) List(ctx context.Context, dir model.Obj, args model.ListArgs)
return nil, err
}

// An empty directory reports totalPages == 0, which would make
// pagesData a zero-length slice and panic on pagesData[0] below.
if firstResp.Meta.TotalPages < 1 {
return []model.Obj{}, nil
}

pagesData := make([][]Object, firstResp.Meta.TotalPages)
pagesData[0] = firstResp.Items

Expand Down
38 changes: 38 additions & 0 deletions drivers/teldrive/driver_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
package teldrive

import (
"context"
"net/http"
"net/http/httptest"
"testing"

"github.com/OpenListTeam/OpenList/v4/drivers/base"
"github.com/OpenListTeam/OpenList/v4/internal/model"
"github.com/go-resty/resty/v2"
)

// An empty directory makes the Teldrive API report totalPages == 0. List used
// to size pagesData by that value and then write pagesData[0], which panicked
// with "index out of range [0] with length 0" on every empty folder.
func TestListEmptyDir(t *testing.T) {
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
w.Header().Set("Content-Type", "application/json")
_, _ = w.Write([]byte(`{"items":[],"meta":{"count":0,"totalPages":0,"currentPage":1}}`))
}))
defer srv.Close()

oldClient := base.RestyClient
base.RestyClient = resty.New()
defer func() { base.RestyClient = oldClient }()

d := &Teldrive{}
d.Address = srv.URL

objs, err := d.List(context.Background(), &model.Object{Path: "/"}, model.ListArgs{})
if err != nil {
t.Fatalf("List returned error: %v", err)
}
if len(objs) != 0 {
t.Fatalf("expected no entries for an empty dir, got %d", len(objs))
}
}