Skip to content

fix(teldrive): avoid index out of range panic when listing an empty dir#2585

Open
SAY-5 wants to merge 1 commit into
OpenListTeam:mainfrom
SAY-5:fix-teldrive-empty-dir-panic
Open

fix(teldrive): avoid index out of range panic when listing an empty dir#2585
SAY-5 wants to merge 1 commit into
OpenListTeam:mainfrom
SAY-5:fix-teldrive-empty-dir-panic

Conversation

@SAY-5

@SAY-5 SAY-5 commented Jun 6, 2026

Copy link
Copy Markdown

Summary / 摘要

When a Teldrive folder is empty the API returns totalPages: 0, so List sized pagesData to length 0 and then panicked on pagesData[0]. This made copying into an empty Teldrive directory (and listing one) crash with index out of range [0] with length 0. Returning early for the no-pages case fixes it; added a regression test that drives List against an empty-listing response.

  • This PR has breaking changes.
    / 此 PR 包含破坏性变更。
  • This PR changes public API, config, storage format, or migration behavior.
    / 此 PR 修改了公开 API、配置、存储格式或迁移行为。
  • This PR requires corresponding changes in related repositories.
    / 此 PR 需要关联仓库同步修改。

Related repository PRs / 关联仓库 PR:

  • OpenList-Frontend: N/A
  • OpenList-Docs: N/A

Related Issues / 关联 Issue

Closes #2538

Testing / 测试

  • go test ./...
  • Manual test / 手动测试: go test ./drivers/teldrive/...; the new regression test hits the index out of range panic without the fix and passes with it.

Checklist / 检查清单

  • I have read CONTRIBUTING.
    / 我已阅读 CONTRIBUTING
  • I confirm this contribution follows the repository license, contribution policy, and code of conduct.
    / 我确认此贡献符合仓库许可证、贡献规范和行为准则。
  • I have formatted the changed code with gofmt, go fmt, or prettier where applicable.
    / 我已按适用情况使用 gofmtgo fmtprettier 格式化变更代码。
  • I have requested review from relevant maintainers or code owners where applicable.
    / 我已在适用情况下请求相关维护者或代码所有者审查。

AI Disclosure / AI 使用声明

  • This PR includes AI-assisted content.
    / 此 PR 包含 AI 辅助内容。

Tools used / 使用工具:

  • ChatGPT
  • Codex
  • GitHub Copilot
  • Claude
  • Gemini
  • Other (please specify) / 其他(请注明):

Usage scope / 使用范围:

  • Code generation / 代码生成

  • Refactoring / 重构

  • Documentation / 文档

  • Tests / 测试

  • Translation / 翻译

  • Review assistance / 审查辅助

  • I have reviewed and validated all AI-assisted content included in this PR.
    / 我已审核并验证此 PR 中的所有 AI 辅助内容。

  • I have ensured that all AI-assisted commits include Co-Authored-By attribution.
    / 我已确保所有 AI 辅助提交都包含 Co-Authored-By 归属信息。

  • I can reproduce all AI-assisted content included in this PR without any AI tools.
    / 我可以在没有任何 AI 工具的情况下重现此 PR 中包含的所有 AI 辅助内容。

Signed-off-by: Sai Asish Y <say.apm35@gmail.com>

@jyxjjj jyxjjj left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution.

This pull request has been approved. However, before it can be merged, please update the PR description to match our default template. Do not remove any existing content; only reorganize or supplement it as needed to fit the template.

Thank you.

@SAY-5

SAY-5 commented Jun 9, 2026

Copy link
Copy Markdown
Author

Reorganized the description to follow the PR template, kept everything that was there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Teldrive 驱动 List 空列表时 panic: index out of range [0] with length 0

2 participants