Skip to content

docs(example): propagate Response.json this-binding fix to README and DocC #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ikorich merged 1 commit into from
Jun 11, 2026
Merged

docs(example): propagate Response.json this-binding fix to README and DocC #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,8 @@ let timer = JSTimer(millisecondsDelay: 1000, isRepeating: true) {
let jsonPromise = JSPromise(jsonObj)
else {
return JSPromise(resolver: { resolve in
resolve(.failure(JSPromise.PromiseError(.string("Unexpected response shape"))))
return .undefined
// Resolver rejection value is a raw JSValue (boxed into PromiseError downstream).
resolve(.failure(.string("Unexpected response shape")))
}).publisher
}
return jsonPromise.publisher
Expand Down
7 changes: 4 additions & 3 deletions Sources/OpenCombineJS/Documentation.docc/OpenCombineJS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,11 +130,12 @@ let timer = JSTimer(millisecondsDelay: 1000, isRepeating: true) {
.flatMap { responseValue -> JSPromise.PromisePublisher in
guard let obj = responseValue.object,
let jsonFn = obj.json.function,
let jsonObj = jsonFn().object,
// `Response.json` must be called with the response as `this` (#24).
let jsonObj = jsonFn(this: obj).object,
let jsonPromise = JSPromise(jsonObj) else {
return JSPromise(resolver: { resolve in
resolve(.failure(JSPromise.PromiseError(.string("bad response"))))
return .undefined
// Resolver rejection value is a raw JSValue (boxed into PromiseError downstream).
resolve(.failure(.string("bad response")))
}).publisher
}
return jsonPromise.publisher
Expand Down
Loading