docs(example): propagate Response.json this-binding fix to README and DocC#26
Merged
Conversation
… and DocC The #24 fix landed in the CI-compiled main.swift but not the two copy-paste teaching examples. The DocC quick-start still showed the unbound jsonFn() call (throws "Illegal invocation" in browsers), and both README and DocC carried a stale JSPromise(resolver:) form (PromiseError-wrapped value + return .undefined) that diverged from the verified source. Both now mirror main.swift exactly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The #24 fix (calling
Response.json()with itsthisbinding) landed in the CI-compiledmain.swiftbut never reached the two copy-paste teaching examples, leaving them broken for anyone who pastes them.Changes
OpenCombineJS.md): replace the unboundjsonFn()— which throws "Illegal invocation" in browsers — withjsonFn(this: obj).JSPromise(resolver:)snippet with the verifiedmain.swiftform (rawJSValuerejection, no spuriousreturn .undefined).Test plan
Documentation-only change confined to markdown code fences; both examples now mirror
main.swiftexactly, with no DocC symbol-link or build impact.Closes #24