Skip to content

Better specify linting comparison files #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrewmogan merged 3 commits into from
Apr 14, 2026
Merged

Better specify linting comparison files #18

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b93b042
Improve linting file name specification
andrewmogan Apr 14, 2026
d0b3869
Fix variable expansion
andrewmogan Apr 14, 2026
7009899
Increase scope of REPO variable
andrewmogan Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions .github/workflows/dunedaq-develop-cpp-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ on:
env:
CALLER_BRANCH: ${{ github.head_ref || github.ref_name }}
TARGET_BRANCH: ${{ github.base_ref || github.ref_name }}
REPO: ${{ github.event.repository.name }}

jobs:
Should_run:
Expand Down Expand Up @@ -122,8 +123,6 @@ jobs:
run: |
BRANCH="$CALLER_BRANCH"

export REPO=$(echo '${{ github.repository }}' | awk -F '/' '{print $2}')

cat << EOF > build_and_lint_package.sh
#!/bin/bash

Expand Down Expand Up @@ -239,8 +238,8 @@ jobs:
}

diff_file_name=linting_diff.txt
pr_linting_results_file=$(find pull_request_linting/ -name "*_linting.log" | tail -n 1)
nightly_linting_results_file=$(find nightly_linting/ -name "*_linting.log" | tail -n 1)
pr_linting_results_file=$(find pull_request_linting/ -name "${REPO}_linting.log" | tail -n 1)
nightly_linting_results_file=$(find nightly_linting/ -name "${REPO}_linting.log" | tail -n 1)

[[ -f "$pr_linting_results_file" ]] || echo "ERROR: No PR results file; exit 1"
[[ -f "$nightly_linting_results_file" ]] || echo "ERROR: No nightly results file; exit 2"
Expand Down