Better specify linting comparison files#18
Merged
andrewmogan merged 3 commits intodevelopfrom Apr 14, 2026
Merged
Conversation
Using wilcard expansion *_linting.log causes multiple files to be specified when this workflow is triggered by a PR that is part of correlated PRs across repos. Using $REPO_linting.log should avoid this.
Contributor
|
Approved. Just from looking at the example Actions, where you see how |
Merged
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In DUNE-DAQ/dfmodules#485, Kurt noticed that the linting comparison check was failing despite only integration test files being changed. I learned that this was because of greedy wildcard expansion in the
findcommand which sets the file names for comparison. This wasn't caught in testing because I didn't test a case where multiple correlated PRs are built together, meaningfindwas finding multiple linting log files. The solution is to simply use the$REPOenvironment variable (now moved to workflow-level scope) when finding log files.Initial failed run here
Successful run using this branch here