Fix flaky day/night world-reader game tests#1666
Draft
Conversation
…he each tick Agent-Logs-Url: https://github.com/CyclopsMC/IntegratedDynamics/sessions/4de51ebd-44f2-4df8-8c53-0d0d2c2c83cd Co-authored-by: rubensworks <440384+rubensworks@users.noreply.github.com>
…k race conditions Agent-Logs-Url: https://github.com/CyclopsMC/IntegratedDynamics/sessions/267090b8-63e7-4515-afdc-86f609ed2fdb Co-authored-by: rubensworks <440384+rubensworks@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
rubensworks
April 20, 2026 06:37
View session
|
coverage: 53.972% (+0.03%) from 53.947% — copilot/fix-gametests-failures into master-26 |
…teSkyBrightness synchronously Agent-Logs-Url: https://github.com/CyclopsMC/IntegratedDynamics/sessions/8e2c5597-58bf-48a8-88e4-3c17b8865e97 Co-authored-by: rubensworks <440384+rubensworks@users.noreply.github.com>
Copilot stopped work on behalf of
rubensworks due to an error
April 22, 2026 18:26
Copilot stopped work on behalf of
rubensworks due to an error
April 23, 2026 17:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
testAspectsReadWorldIsDayAndIsNightfailuresrunAfterDelay(1)race condition: other tests' environment teardowns could reset the clock during the 1-tick wait, causingskyDarkento reflect the wrong timerunAfterDelaywith direct synchronous calls:invalidateTickCache()+updateSkyBrightness()immediately aftersetTotalTicks, then assert without waitingOptional.ifPresent()withgetOrThrow()so clock-lookup failures are immediately visible rather than silently skippedskyDarkenimmediately — further root-cause analysis was cut off by time