Skip to content

London | 26-ITP-January | Eugenie Ahangama | Sprint 3 | dead code #1004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Eugenie-A wants to merge 3 commits into
base: main
Choose a base branch
from
Open

London | 26-ITP-January | Eugenie Ahangama | Sprint 3 | dead code #1004

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d753e5f
Removed dead code in sayHello function (unreachable log, unused var, …
Eugenie-A Feb 21, 2026
8c21873
Removed dead code: unused capitalisedPets, petsStartingWithH, logPets…
Eugenie-A Feb 21, 2026
44c6d1d
Fix: Removed capitalisePets and logPets as they are not used in produ…
Eugenie-A Mar 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions Sprint-3/3-dead-code/exercise-1.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,13 @@
// Find the instances of unreachable and redundant code - remove them!
// The sayHello function should continue to work for any reasonable input it's given.

let testName = "Jerry";
const greeting = "hello";

function sayHello(greeting, name) {
const greetingStr = greeting + ", " + name + "!";
return `${greeting}, ${name}!`;
console.log(greetingStr);
}

testName = "Aman";
const testName = "Aman";

const greetingMessage = sayHello(greeting, testName);

Expand Down
5 changes: 0 additions & 5 deletions Sprint-3/3-dead-code/exercise-2.js
View file
Open in desktop
Copy link

@hkavalikas hkavalikas Mar 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't quite right; the implementation and results you are printing have changed. We want the output to stay the same while we make sure the pet variable doesn't get modified.

Copy link
Author

@Eugenie-A Eugenie-A Mar 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the review.
I removed capitalisedPets and logPets since neither is used anywhere in the program flow leading to the final console.log.
The output remains identical ({ 'HAMSTER': 3, 'HORSE': 1 }), pets is untouched, and countAndCapitalisePets still behaves correctly on any string array.

Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,8 @@
// The countAndCapitalisePets function should continue to work for any reasonable input it's given, and you shouldn't modify the pets variable.

const pets = ["parrot", "hamster", "horse", "dog", "hamster", "cat", "hamster"];
const capitalisedPets = pets.map((pet) => pet.toUpperCase());
const petsStartingWithH = pets.filter((pet) => pet[0] === "h");

function logPets(petsArr) {
petsArr.forEach((pet) => console.log(pet));
}

function countAndCapitalisePets(petsArr) {
const petCount = {};

Expand Down