Skip to content

London | 26-ITP-January | Eugenie Ahangama | Sprint 3 | dead code#1004

Open
Eugenie-A wants to merge 3 commits intoCodeYourFuture:mainfrom
Eugenie-A:coursework/sprint-3-dead-code
Open

London | 26-ITP-January | Eugenie Ahangama | Sprint 3 | dead code#1004
Eugenie-A wants to merge 3 commits intoCodeYourFuture:mainfrom
Eugenie-A:coursework/sprint-3-dead-code

Conversation

@Eugenie-A
Copy link

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Completed all exercises in dead code directory.

Questions

N/A

@Eugenie-A Eugenie-A added 🏕 Priority Mandatory This work is expected 🐇 Size Small Around an hour 📅 Sprint 3 Assigned during Sprint 3 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Submit:PR Module-Structuring-And-Testing-Data The name of the module. Optional This is an optional task to be attempted once trainees have completed the core tasks labels Feb 21, 2026
@hkavalikas hkavalikas self-requested a review March 1, 2026 16:20
@hkavalikas hkavalikas added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't quite right; the implementation and results you are printing have changed. We want the output to stay the same while we make sure the pet variable doesn't get modified.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the review.
I removed capitalisedPets and logPets since neither is used anywhere in the program flow leading to the final console.log.
The output remains identical ({ 'HAMSTER': 3, 'HORSE': 1 }), pets is untouched, and countAndCapitalisePets still behaves correctly on any string array.

@hkavalikas hkavalikas added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Mar 1, 2026
@Eugenie-A Eugenie-A added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Mar 1, 2026
@hkavalikas hkavalikas added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 2, 2026
@hkavalikas hkavalikas added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Mar 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Module-Structuring-And-Testing-Data The name of the module. Optional This is an optional task to be attempted once trainees have completed the core tasks 🏕 Priority Mandatory This work is expected 🐇 Size Small Around an hour 📅 Sprint 3 Assigned during Sprint 3 of this module Submit:PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants