Skip to content

blackboard: record the W1a-#9 masking-primitive ship (PR #285) - #286

Merged
AdaWorldAPI merged 1 commit into
masterfrom
claude/blackboard-285
Aug 31, 2026
Merged

blackboard: record the W1a-#9 masking-primitive ship (PR #285)#286
AdaWorldAPI merged 1 commit into
masterfrom
claude/blackboard-285

Conversation

@AdaWorldAPI

@AdaWorldAPI AdaWorldAPI commented Aug 31, 2026

Copy link
Copy Markdown
Owner

Post-merge blackboard entry per this repo's agent protocol ("after completing work, update the blackboard with decisions and loose ends"): what #285 shipped (andnot/ternlog on all six dispatch arms, facade-resident named immediates, IMM guards, doc examples), the declined nightly finding with its reason, and the one deliberate loose end (whole-crate wasm compile-check blocked by the pre-existing getrandom gap — wasm-simd-parity remains that arm's verification home).

Docs-only diff.

🤖 Generated with Claude Code

https://claude.ai/code/session_01KCGhDYoQBXs3poaR7sFuqp


Generated by Claude Code

Summary by CodeRabbit

  • New Features

    • Added andnot and ternlog masking primitives across supported SIMD implementations.
    • Added convenient named immediate values through the common interface.
    • Integrated the new masking operations for use by lance-graph consumers.
  • Documentation

    • Documented the new masking primitives and their platform support.
    • Added compile-time safeguards and clarified WebAssembly verification limitations.

@coderabbitai

coderabbitai Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 41b9ad8f-fcdb-46ff-b39a-1c00c0a9f5b6

📥 Commits

Reviewing files that changed from the base of the PR and between 5bc60cb and ce7976a.

📒 Files selected for processing (1)
  • .claude/blackboard.md

Included review availability: 0 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 3 reviews per hour.


📝 Walkthrough

Walkthrough

The blackboard now records andnot and ternlog masking support across six SIMD backends, facade-level immediates, compile-time validation, documentation and tests, wasm verification limits, and lance-graph integration.

Changes

SIMD masking primitives

Layer / File(s) Summary
Masking support status documentation
.claude/blackboard.md
Adds a latest-status entry for U64x8 and U32x16 masking primitives. It documents backend coverage, facade constants, immediate validation, tests, wasm verification scope, and lance-graph integration. It removes the prior “latest” label from the blake3 entry.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to ce797

This is a docs-only blackboard update with no production or runtime behavior change; no actionable merge-blocking risk remains.

Suggested reviewers: claude

Poem

A rabbit checks the SIMD lane,
Andnot hops through sun and rain.
Ternlog wears a mask of gold,
Six backends march in rows so bold.
The blackboard marks the path ahead.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the blackboard documentation update and the recorded andnot/ternlog masking-primitive shipment for PR #285.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)


Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ce7976a81b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .claude/blackboard.md
Comment on lines +17 to +18
out on x86 — three bots caught it independently), and every portable arm
carries the avx512-equivalent compile-time IMM domain guard. Doc examples

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Add the missing scalar U64 IMM guard before calling it complete

For the scalar backend's U64x8 only, src/simd_scalar.rs:2087 enters the minterm logic without the const { assert!(IMM >= 0 && IMM <= 255, ...) } present on U32x16 and the other portable implementations. Consequently, calls such as U64x8::ternlog::<256> compile and silently ignore the out-of-domain bits, so this entry incorrectly records the IMM-domain work as complete; either add that guard or retain this as a loose end.

Useful? React with 👍 / 👎.

Comment thread .claude/blackboard.md
Comment on lines +19 to +20
on all twelve method sites; the avx512 ones execute in this environment's
doc-test run. Declined finding, reasons on the PR thread: extending the

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Do not claim the doctests exercise the AVX-512 backend

On the repository's default x86-64-v3 doctest build, each example imports ndarray::simd::{U64x8,U32x16}, whose facade exports the AVX2 types; even examples extracted from simd_avx512.rs therefore execute AVX2 methods rather than the AVX-512 implementations. This environment also has no AVX-512 hardware, so the entry overstates the native backend's runtime verification; record these examples as compile-only/default-facade coverage unless they were actually run on an AVX-512 host.

AGENTS.md reference: AGENTS.md:L22-L22

Useful? React with 👍 / 👎.

@AdaWorldAPI
AdaWorldAPI merged commit e03fbd9 into master Aug 31, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants