review follow-up: scalar U64x8 IMM guard; avx512 verification measured, not claimed - #287
Conversation
…d, not claimed Codex P2 pair on the record PR, both accepted: - src/simd_scalar.rs: U64x8::ternlog was missing the inline const IMM guard the record marked complete (U32x16 had it) - ternlog::<256> compiled and silently truncated. Guard added, doc paragraph aligned with the every-backend wording. - .claude/blackboard.md: the claim that the avx512 doc examples execute in the doc-test run is retired (default v3 facade resolves the examples to the avx2 types - default-facade coverage, not backend verification). Replaced with a measurement: this host carries avx512f and all five w1a9 facade tests pass under CARGO_BUILD_RUSTFLAGS=-Ctarget-cpu=x86-64-v4 - hardware-executed avx512 runtime verification, recorded as such. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KCGhDYoQBXs3poaR7sFuqp
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
Included review availability: 1 review is currently available. Your included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour. 📝 WalkthroughWalkthroughThe change adds compile-time validation for scalar ChangesTernlog immediate validation
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to The PR adds the missing scalar immediate-value guard and corrects the verification documentation; no actionable merge-blocking risk remains after normal checks and review. Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (1 skipped: 1 unsupported.) ✨ Finishing Touches📝 Generate docstrings
Comment |
What
Addresses the two codex P2 comments on the merged #286 record — both accepted, both verified by measurement:
The missing guard was real (
src/simd_scalar.rs): scalarU64x8::ternloglacked the inline const IMM guard that the record marked complete —ternlog::<256>compiled and silently truncated (itsU32x16sibling had the guard;U64x8did not). Guard added with the identical message every other arm carries; doc paragraph aligned to the every-backend wording with thecrate::simd::ternlogpointer.The doctest claim was overstated (
.claude/blackboard.md): under the default v3 config the doc examples import the facade types, so the "avx512 examples execute in the doc-test run" sentence described default-facade coverage, not backend verification. Retired via a dated ⊘ correction — and replaced with an actual measurement: this host carries avx512f (cpuinfo), and all five w1a9 facade tests pass underCARGO_BUILD_RUSTFLAGS='-Ctarget-cpu=x86-64-v4'— hardware-executed AVX-512 runtime verification of the backend, recorded as what it is.Verification
cargo test --lib -- w1a9(default v3): 5/5 greenCARGO_BUILD_RUSTFLAGS='-Ctarget-cpu=x86-64-v4' cargo test --libw1a9 set: 5/5 green (the new avx512 runtime anchor)🤖 Generated with Claude Code
https://claude.ai/code/session_01KCGhDYoQBXs3poaR7sFuqp
Generated by Claude Code
Summary by CodeRabbit
Bug Fixes
U64x8::ternlogtruth-table values are within the supported range.Documentation