Imporve custom compress speed via merging the multi Constraints and other optimizations as follows:#178
Open
yuruiyin wants to merge 2 commits intozetbaitsu:masterfrom
Open
Imporve custom compress speed via merging the multi Constraints and other optimizations as follows:#178yuruiyin wants to merge 2 commits intozetbaitsu:masterfrom
yuruiyin wants to merge 2 commits intozetbaitsu:masterfrom
Conversation
…ther optimations as follows: 1. merge multi ResolutionConstraints and QualityConstraints and FormatConstraints (without DestinationConstraint and SizeConstraint) into only one DefaultConstraint 2. Move the SizeConstraint to the last post since it can reduce the number of compress times in this type of SizeConstraint. 3. In SizeConstraint, we can avoid performing the compression if the bitmap compress format is png. 4. If there is a DestinationConstraint, we can reduce the number of copy file times via using the dest file from DestinationConstraint in the method of copyToCache.
Author
|
@zetbaitsu hi, plz help review, thanks~ |
… improve-compress-speed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue description:
bitmap.compress()which is just like one(constraint) by one(constraint). For example, the code is as follows:if each constraint spend 2s, then the compression of the above will spend 10s(the sum of each time cost). The result is not what we want.
Solution:
ResolutionConstraintsandQualityConstraintsandFormatConstraints(withoutDestinationConstraintandSizeConstraint) into only oneDefaultConstraint.SizeConstraintto the last post since it can reduce the number of compress times in this type ofSizeConstraint.SizeConstraint, we can avoid performing the compression if the bitmap compress format is png.DestinationConstraint, we can reduce the number of copy file times via using the dest file fromDestinationConstraintin the method ofcopyToCache.