Fix portable project build#40
Closed
Sean-Kenneth-Doherty wants to merge 1 commit into
Closed
Conversation
3e2a6b9 to
7f654c4
Compare
Author
|
Closing this under my tightened quality bar rather than leaving a source-build-only draft in your queue. The branch has useful local build/load checks, but there is no current issue or maintainer request behind it, and it does not change runtime behavior. I will not reopen unless there is a concrete maintainer-requested build/release need or a player-facing defect with proof. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The project file does not build cleanly outside a Windows/Visual Studio layout. On Linux with KSP 1.12.5 assemblies,
xbuildstops before compilation becauseSolarScience.csprojunconditionally imports the Visual Studio TextTemplating targets path:The project also references
Properties\Version.cs, while the tracked generated file isProperties\version.cs, which breaks on case-sensitive filesystems.Changes
Properties\version.csfilename in the project file.TextTransform.exepre-build step conditional.This is intentionally build-only; no runtime C# source files are changed.
Validation
Environment: KSP 1.12.5.3190 assemblies from Steam, Mono/xbuild 14.0 on Linux.
origin/masterproject file: fails before compilation with the missing TextTemplating targets import.Build result: succeeded, producing
SolarScience.dllwith SHA-256f3d894d6296f62df7af4ffc1413cbf2c0a0eac6ac27d19c8902e591f58dc5baa.Additional KSP load check: installed that DLL into a disposable KSP 1.12.5.3190 GameData with SolarScience assets. A proof addon reached MainMenu, found both
KMIandSTEREO, called their module startup path, loaded both opening audio clips, and reportedOVERALL result=PASS. The log had noNullReferenceException,TypeLoadException, orMissingMethodException.