Skip to content

Misc Fixes for Wii Map TUs#3168

Open
SuperDude88 wants to merge 7 commits into
zeldaret:mainfrom
SuperDude88:wii-map
Open

Misc Fixes for Wii Map TUs#3168
SuperDude88 wants to merge 7 commits into
zeldaret:mainfrom
SuperDude88:wii-map

Conversation

@SuperDude88

Copy link
Copy Markdown
Contributor

Also did some minor updates to the splits/symbols for those files, new to that process so they should probably be taken with extra scrutiny. The symbols with $<numbers> at the end were just taken from objdiff, I didn't check if the map had "correct" values for those.

Not sure if all of the float math is right, tried to confirm it was mostly regalloc but not entirely certain

Couple of guessed inline names that seemed to make sense
New to updating these but tried to correct some odd ones
I think these are closer to correct
@decomp-dev

decomp-dev Bot commented Jul 4, 2026

Copy link
Copy Markdown

Report for Shield (c8fa8c9 - 68a0a41)

📈 Matched code: 50.28% (+0.00%, +384 bytes)

✅ 1 new match
Unit Item Bytes Before After
framework/d/d_map dMap_c::calcMapCmPerTexel(int, float*) +3 99.30% 100.00%

Report for ShieldD (c8fa8c9 - 68a0a41)

📈 3 improvements in unmatched items
Unit Item Bytes Before After
framework/d/d_menu_map_common dMenuMapCommon_c::drawIcon(float, float, float, float) +60 94.08% 96.78%
framework/d/d_map dMap_c::calcMapCmPerTexel(int, float*) +52 88.10% 94.74%
framework/d/d_menu_dmap dMenu_DmapBg_c::draw() +11 84.09% 84.52%

Report for RZDE01_02 (c8fa8c9 - 68a0a41)

📈 Matched code: 54.83% (+0.15%, +15504 bytes)
Total data: 3167246 bytes (-20 bytes)
📈 Matched data: 56.43% (+0.03%, +884 bytes)

✅ 44 new matches
Unit Item Bytes Before After
framework/d/d_menu_dmap dMenu_Dmap_c::_move() +416 41.65% 100.00%
framework/d/d_menu_fmap dMenu_Fmap_c::getNextStatus(unsigned char*) +370 18.19% 100.00%
framework/d/d_menu_dmap dMenu_DmapBg_c::setCButtonString(unsigned long) +152 0.63% 100.00%
framework/d/d_menu_map_common dMenuMapCommon_c::drawIcon(float, float, float, float) +143 91.14% 100.00%
framework/d/d_menu_fmap2D dMenu_Fmap2DBack_c::~dMenu_Fmap2DBack_c() +106 84.80% 100.00%
framework/d/d_map dMap_c::_move(float, float, int, float) +57 97.17% 100.00%
framework/d/d_menu_fmap dMenu_Fmap_c::_create() +41 97.82% 100.00%
framework/d/d_menu_map_common dMenuMapCommon_c::getMirrorCenterPosX(float, float) +40 0.00% 100.00%
framework/d/d_menu_fmap2D dMenu_Fmap2DTop_c::setAButtonString(unsigned long, unsigned char) +39 83.16% 100.00%
framework/d/d_menu_dmap dMenu_Dmap_c::floorChangeMode() +29 88.91% 100.00%
framework/d/d_menu_dmap dMenu_Dmap_c::zoomIn_proc() +28 83.33% 100.00%
framework/d/d_menu_dmap dMenu_Dmap_c::zoomOut_proc() +28 82.44% 100.00%
framework/d/d_menu_dmap dMenu_Dmap_c::isMapMoveState() +21 71.89% 100.00%
framework/d/d_menu_fmap2D dMenu_Fmap2DTop_c::draw() +21 93.47% 100.00%
framework/d/d_event_manager .rodata +16 0.00% 100.00%
framework/d/d_map_path dRenderingFDAmap_c::preRenderingMap() +10 97.80% 100.00%
framework/d/d_menu_dmap_map dMenu_StageMapCtrl_c::getTreasureList(float*, float*, signed char*, unsigned char*, signed char*) +9 97.47% 100.00%
framework/d/d_menu_fmap2D .sdata2 +9 90.91% 100.00%
framework/d/d_menu_fmap2D .sbss +8 0.00% 100.00%
framework/d/d_map .sdata2 +5 95.65% 100.00%
framework/d/d_map_path .sdata2 +5 85.71% 100.00%
framework/d/d_menu_dmap_map .sdata2 +5 96.30% 100.00%
framework/d/d_menu_dmap_map dMenu_StageMapCtrl_c::getPlayerDrawInfo(float*, float*, short*) const +5 96.91% 100.00%
framework/d/d_menu_dmap_map dMenu_StageMapCtrl_c::getRestartDrawInfo(float*, float*, short*) const +5 97.16% 100.00%
framework/d/d_menu_dmap_map dMenu_StageMapCtrl_c::cnvPosTo2Dpos(float, float, float*, float*) const +4 96.43% 100.00%
framework/d/d_map dMap_c::calcMapCmPerTexel(int, float*) +3 99.26% 100.00%
framework/d/d_menu_map_common .sdata2 +3 96.00% 100.00%
framework/d/d_menu_dmap dMenu_DmapBg_c::setFloorMessage() +2 99.95% 100.00%
framework/d/d_map_path dMpath_n::dTexObjAggregate_c::create() +1 99.86% 100.00%
framework/d/d_map_path_dmap renderingPlusDoorAndCursor_c::drawTreasure() +1 99.97% 100.00%

...and 14 more new matches

📈 44 improvements in unmatched items
Unit Item Bytes Before After
framework/d/d_menu_fmap2D dMenu_Fmap2DBack_c::allmap_move2(STControl*) +720 48.51% 94.39%
framework/d/d_menu_fmap2D dMenu_Fmap2DBack_c::regionMapMove(STControl*) +678 50.70% 94.37%
framework/d/d_menu_dmap dMenu_DmapBg_c::dpdMove(signed char, signed char, signed char, unsigned char*, unsigned char) +504 0.93% 84.87%
framework/d/d_menu_fmap2D .data +352 17.72% 99.18%
framework/d/d_menu_fmap dMenu_Fmap_c::region_map_proc() +285 77.64% 95.54%
framework/d/d_menu_dmap dMenu_DmapBg_c::setJButtonString(unsigned long) +273 2.75% 98.87%
framework/d/d_menu_fmap dMenu_Fmap_c::spot_map_proc() +252 66.25% 82.64%
framework/d/d_menu_fmap2D dMenu_Fmap2DBack_c::draw() +221 80.11% 89.69%
framework/d/d_menu_dmap dMenu_DmapBg_c::baseScreenInit() +195 64.69% 87.63%
framework/d/d_menu_fmap2D dMenu_Fmap2DBack_c::regionTextureDraw() +167 62.14% 79.96%
framework/d/d_menu_fmap2D dMenu_Fmap2DBack_c::drawDebugStageArea() +150 69.38% 93.77%
framework/d/d_menu_fmap2D dMenu_Fmap2DBack_c::dMenu_Fmap2DBack_c() +129 86.96% 93.82%
framework/d/d_menu_fmap2D dMenu_Fmap2DTop_c::dMenu_Fmap2DTop_c(JKRExpHeap*, STControl*) +123 92.93% 98.95%
framework/d/d_menu_dmap dMenu_Dmap_c::screenInit() +117 97.02% 99.76%
framework/d/d_menu_fmap dMenu_Fmap_c::all_map_proc() +108 92.45% 99.23%
framework/d/d_menu_dmap dMenu_DmapBg_c::~dMenu_DmapBg_c() +107 90.33% 97.53%
framework/d/d_menu_dmap .rodata +96 70.65% 81.50%
framework/d/d_menu_fmap dMenu_Fmap_c::portalWarpMapMove(STControl*) +90 76.08% 93.93%
framework/d/d_menu_dmap dMenu_DmapBg_c::mapScreenInit() +88 87.24% 93.21%
framework/d/d_menu_dmap dMenu_DmapBg_c::draw() +62 86.21% 89.13%
framework/d/d_menu_fmap2D dMenu_Fmap2DBack_c::stageMapMove(STControl*, unsigned char, bool) +62 57.50% 60.53%
framework/d/d_menu_fmap dMenu_Fmap_c::drawPlayEnterIcon() +47 74.60% 92.62%
framework/d/d_menu_fmap dMenu_Fmap_c::drawIcon(float, bool) +46 84.72% 91.61%
framework/d/d_menu_fmap dMenu_Fmap_c::spot_map_init() +41 85.19% 97.81%
framework/d/d_menu_fmap2D dMenu_Fmap2DBack_c::scrollAreaDraw() +40 71.19% 78.31%
framework/d/d_menu_fmap2D dMenu_Fmap2DBack_c::worldGridDraw() +34 73.08% 76.65%
framework/d/d_map_path_dmap dMpath_c::setPointer(signed char, void*, int) +32 73.51% 83.04%
framework/d/d_menu_fmap2D dMenu_Fmap2DBack_c::worldOriginDraw() +32 63.73% 76.77%
framework/d/d_menu_fmap2D dMenu_Fmap2DBack_c::regionGridDraw() +24 75.02% 77.47%
framework/d/d_menu_fmap2D dMenu_Fmap2DBack_c::regionOriginDraw() +24 77.63% 87.80%

...and 14 more improvements in unmatched items

📉 1 regression in an unmatched item
Unit Item Bytes Before After
framework/d/d_menu_dmap .sdata +2 60.00% 58.54%

Report for DZDE01 (c8fa8c9 - 68a0a41)

📈 Matched code: 52.30% (+0.08%, +7764 bytes)
📈 Matched data: 55.20% (+0.01%, +288 bytes)

✅ 23 new matches
Unit Item Bytes Before After
framework/d/d_menu_dmap dMenu_Dmap_c::_move() +416 41.65% 100.00%
framework/d/d_menu_fmap dMenu_Fmap_c::getNextStatus(unsigned char*) +370 18.19% 100.00%
framework/d/d_menu_dmap dMenu_DmapBg_c::setCButtonString(unsigned long) +152 0.63% 100.00%
framework/d/d_menu_map_common dMenuMapCommon_c::drawIcon(float, float, float, float) +143 91.14% 100.00%
framework/d/d_menu_fmap2D dMenu_Fmap2DBack_c::~dMenu_Fmap2DBack_c() +106 84.80% 100.00%
framework/d/d_menu_fmap dMenu_Fmap_c::_create() +41 97.82% 100.00%
framework/d/d_menu_map_common dMenuMapCommon_c::getMirrorCenterPosX(float, float) +40 0.00% 100.00%
framework/d/d_menu_fmap2D dMenu_Fmap2DTop_c::setAButtonString(unsigned long, unsigned char) +39 83.16% 100.00%
framework/d/d_menu_dmap dMenu_Dmap_c::floorChangeMode() +29 88.91% 100.00%
framework/d/d_menu_dmap dMenu_Dmap_c::zoomIn_proc() +28 83.33% 100.00%
framework/d/d_menu_dmap dMenu_Dmap_c::zoomOut_proc() +28 82.44% 100.00%
framework/d/d_menu_dmap dMenu_Dmap_c::isMapMoveState() +21 71.89% 100.00%
framework/d/d_menu_fmap2D dMenu_Fmap2DTop_c::draw() +21 93.47% 100.00%
framework/d/d_menu_dmap_map dMenu_StageMapCtrl_c::getTreasureList(float*, float*, signed char*, unsigned char*, signed char*) +9 97.47% 100.00%
framework/d/d_menu_fmap2D .sdata2 +9 90.91% 100.00%
framework/d/d_menu_fmap2D .sbss +8 0.00% 100.00%
framework/d/d_map .sdata2 +5 95.65% 100.00%
framework/d/d_map_path .sdata2 +5 85.71% 100.00%
framework/d/d_menu_dmap_map dMenu_StageMapCtrl_c::getPlayerDrawInfo(float*, float*, short*) const +5 96.91% 100.00%
framework/d/d_menu_dmap_map dMenu_StageMapCtrl_c::getRestartDrawInfo(float*, float*, short*) const +5 97.16% 100.00%
framework/d/d_menu_dmap_map dMenu_StageMapCtrl_c::cnvPosTo2Dpos(float, float, float*, float*) const +4 96.43% 100.00%
framework/d/d_map dMap_c::calcMapCmPerTexel(int, float*) +3 99.26% 100.00%
framework/d/d_menu_map_common .sdata2 +3 96.00% 100.00%
📈 38 improvements in unmatched items
Unit Item Bytes Before After
framework/d/d_menu_fmap2D dMenu_Fmap2DBack_c::allmap_move2(STControl*) +720 48.51% 94.39%
framework/d/d_menu_fmap2D dMenu_Fmap2DBack_c::regionMapMove(STControl*) +678 50.70% 94.37%
framework/d/d_menu_dmap dMenu_DmapBg_c::dpdMove(signed char, signed char, signed char, unsigned char*, unsigned char) +504 0.93% 84.87%
framework/d/d_menu_fmap2D .data +352 17.72% 99.18%
framework/d/d_menu_fmap dMenu_Fmap_c::region_map_proc() +285 77.64% 95.54%
framework/d/d_menu_dmap dMenu_DmapBg_c::setJButtonString(unsigned long) +273 2.75% 98.80%
framework/d/d_menu_fmap dMenu_Fmap_c::spot_map_proc() +252 66.25% 82.64%
framework/d/d_menu_fmap2D dMenu_Fmap2DBack_c::draw() +221 80.11% 89.69%
framework/d/d_menu_dmap dMenu_DmapBg_c::baseScreenInit() +195 64.69% 87.61%
framework/d/d_menu_fmap2D dMenu_Fmap2DBack_c::regionTextureDraw() +167 62.14% 79.96%
framework/d/d_menu_fmap2D dMenu_Fmap2DBack_c::drawDebugStageArea() +150 69.38% 93.77%
framework/d/d_menu_fmap2D dMenu_Fmap2DBack_c::dMenu_Fmap2DBack_c() +129 86.96% 93.82%
framework/d/d_menu_fmap2D dMenu_Fmap2DTop_c::dMenu_Fmap2DTop_c(JKRExpHeap*, STControl*) +123 92.92% 98.94%
framework/d/d_menu_dmap dMenu_Dmap_c::screenInit() +117 97.02% 99.76%
framework/d/d_menu_fmap dMenu_Fmap_c::all_map_proc() +108 92.45% 99.23%
framework/d/d_menu_dmap dMenu_DmapBg_c::~dMenu_DmapBg_c() +107 90.33% 97.53%
framework/d/d_menu_dmap .rodata +96 70.65% 81.50%
framework/d/d_menu_fmap dMenu_Fmap_c::portalWarpMapMove(STControl*) +90 76.08% 93.93%
framework/d/d_menu_dmap dMenu_DmapBg_c::mapScreenInit() +88 87.24% 93.21%
framework/d/d_menu_dmap dMenu_DmapBg_c::draw() +62 86.21% 89.13%
framework/d/d_menu_fmap2D dMenu_Fmap2DBack_c::stageMapMove(STControl*, unsigned char, bool) +62 57.50% 60.53%
framework/d/d_map dMap_c::_move(float, float, int, float) +56 97.16% 99.99%
framework/d/d_menu_fmap dMenu_Fmap_c::drawPlayEnterIcon() +47 74.60% 92.62%
framework/d/d_menu_fmap dMenu_Fmap_c::drawIcon(float, bool) +46 84.72% 91.61%
framework/d/d_menu_fmap dMenu_Fmap_c::spot_map_init() +41 85.19% 97.81%
framework/d/d_menu_fmap2D dMenu_Fmap2DBack_c::scrollAreaDraw() +40 71.19% 78.31%
framework/d/d_menu_fmap2D dMenu_Fmap2DBack_c::worldGridDraw() +34 73.08% 76.65%
framework/d/d_map_path_dmap dMpath_c::setPointer(signed char, void*, int) +32 73.51% 83.04%
framework/d/d_menu_fmap2D dMenu_Fmap2DBack_c::worldOriginDraw() +32 63.73% 76.77%
framework/d/d_menu_fmap2D dMenu_Fmap2DBack_c::regionGridDraw() +24 75.02% 77.47%

...and 8 more improvements in unmatched items


Report for GZ2P01 (c8fa8c9 - 68a0a41)

No changes

Report for GZ2E01 (c8fa8c9 - 68a0a41)

No changes

Report for RZDJ01 (c8fa8c9 - 68a0a41)

📈 Matched code: 53.95% (+0.10%, +10204 bytes)
📈 Matched data: 56.01% (+0.01%, +288 bytes)

✅ 25 new matches
Unit Item Bytes Before After
framework/d/d_menu_dmap dMenu_Dmap_c::_move() +416 41.65% 100.00%
framework/d/d_menu_fmap dMenu_Fmap_c::getNextStatus(unsigned char*) +370 18.19% 100.00%
framework/d/d_menu_dmap dMenu_DmapBg_c::setCButtonString(unsigned long) +152 0.63% 100.00%
framework/d/d_menu_map_common dMenuMapCommon_c::drawIcon(float, float, float, float) +143 91.14% 100.00%
framework/d/d_menu_fmap2D dMenu_Fmap2DBack_c::~dMenu_Fmap2DBack_c() +106 84.80% 100.00%
framework/d/d_map dMap_c::_move(float, float, int, float) +57 97.17% 100.00%
framework/d/d_menu_fmap dMenu_Fmap_c::_create() +41 97.82% 100.00%
framework/d/d_menu_map_common dMenuMapCommon_c::getMirrorCenterPosX(float, float) +40 0.00% 100.00%
framework/d/d_menu_fmap2D dMenu_Fmap2DTop_c::setAButtonString(unsigned long, unsigned char) +39 83.16% 100.00%
framework/d/d_menu_dmap dMenu_Dmap_c::floorChangeMode() +29 88.91% 100.00%
framework/d/d_menu_dmap dMenu_Dmap_c::zoomIn_proc() +28 83.33% 100.00%
framework/d/d_menu_dmap dMenu_Dmap_c::zoomOut_proc() +28 82.44% 100.00%
framework/d/d_menu_dmap dMenu_Dmap_c::isMapMoveState() +21 71.89% 100.00%
framework/d/d_menu_fmap2D dMenu_Fmap2DTop_c::draw() +21 93.47% 100.00%
framework/d/d_map_path dRenderingFDAmap_c::preRenderingMap() +10 97.80% 100.00%
framework/d/d_menu_dmap_map dMenu_StageMapCtrl_c::getTreasureList(float*, float*, signed char*, unsigned char*, signed char*) +9 97.47% 100.00%
framework/d/d_menu_fmap2D .sdata2 +9 90.91% 100.00%
framework/d/d_menu_fmap2D .sbss +8 0.00% 100.00%
framework/d/d_map .sdata2 +5 95.65% 100.00%
framework/d/d_map_path .sdata2 +5 85.71% 100.00%
framework/d/d_menu_dmap_map dMenu_StageMapCtrl_c::getPlayerDrawInfo(float*, float*, short*) const +5 96.91% 100.00%
framework/d/d_menu_dmap_map dMenu_StageMapCtrl_c::getRestartDrawInfo(float*, float*, short*) const +5 97.16% 100.00%
framework/d/d_menu_dmap_map dMenu_StageMapCtrl_c::cnvPosTo2Dpos(float, float, float*, float*) const +4 96.43% 100.00%
framework/d/d_map dMap_c::calcMapCmPerTexel(int, float*) +3 99.26% 100.00%
framework/d/d_menu_map_common .sdata2 +3 96.00% 100.00%
📈 36 improvements in unmatched items
Unit Item Bytes Before After
framework/d/d_menu_fmap2D dMenu_Fmap2DBack_c::allmap_move2(STControl*) +720 48.51% 94.39%
framework/d/d_menu_fmap2D dMenu_Fmap2DBack_c::regionMapMove(STControl*) +678 50.70% 94.37%
framework/d/d_menu_dmap dMenu_DmapBg_c::dpdMove(signed char, signed char, signed char, unsigned char*, unsigned char) +504 0.93% 84.87%
framework/d/d_menu_fmap2D .data +352 17.72% 99.18%
framework/d/d_menu_fmap dMenu_Fmap_c::region_map_proc() +285 77.64% 95.54%
framework/d/d_menu_dmap dMenu_DmapBg_c::setJButtonString(unsigned long) +273 2.75% 98.80%
framework/d/d_menu_fmap dMenu_Fmap_c::spot_map_proc() +252 66.25% 82.64%
framework/d/d_menu_fmap2D dMenu_Fmap2DBack_c::draw() +221 80.11% 89.69%
framework/d/d_menu_dmap dMenu_DmapBg_c::baseScreenInit() +195 64.67% 87.59%
framework/d/d_menu_fmap2D dMenu_Fmap2DBack_c::regionTextureDraw() +167 62.14% 79.96%
framework/d/d_menu_fmap2D dMenu_Fmap2DBack_c::drawDebugStageArea() +150 69.38% 93.77%
framework/d/d_menu_fmap2D dMenu_Fmap2DBack_c::dMenu_Fmap2DBack_c() +129 86.96% 93.82%
framework/d/d_menu_fmap2D dMenu_Fmap2DTop_c::dMenu_Fmap2DTop_c(JKRExpHeap*, STControl*) +123 92.91% 98.93%
framework/d/d_menu_dmap dMenu_Dmap_c::screenInit() +117 97.02% 99.76%
framework/d/d_menu_fmap dMenu_Fmap_c::all_map_proc() +108 92.45% 99.23%
framework/d/d_menu_dmap dMenu_DmapBg_c::~dMenu_DmapBg_c() +107 90.33% 97.53%
framework/d/d_menu_fmap dMenu_Fmap_c::portalWarpMapMove(STControl*) +90 76.08% 93.93%
framework/d/d_menu_dmap dMenu_DmapBg_c::mapScreenInit() +88 87.24% 93.21%
framework/d/d_menu_dmap .rodata +86 70.65% 80.38%
framework/d/d_menu_dmap dMenu_DmapBg_c::draw() +62 86.21% 89.13%
framework/d/d_menu_fmap2D dMenu_Fmap2DBack_c::stageMapMove(STControl*, unsigned char, bool) +62 57.50% 60.53%
framework/d/d_menu_fmap dMenu_Fmap_c::drawPlayEnterIcon() +47 74.60% 92.62%
framework/d/d_menu_fmap dMenu_Fmap_c::drawIcon(float, bool) +46 84.72% 91.61%
framework/d/d_menu_fmap dMenu_Fmap_c::spot_map_init() +41 85.19% 97.81%
framework/d/d_menu_fmap2D dMenu_Fmap2DBack_c::scrollAreaDraw() +40 71.19% 78.31%
framework/d/d_menu_fmap2D dMenu_Fmap2DBack_c::worldGridDraw() +34 73.08% 76.65%
framework/d/d_map_path_dmap dMpath_c::setPointer(signed char, void*, int) +32 73.51% 83.04%
framework/d/d_menu_fmap2D dMenu_Fmap2DBack_c::worldOriginDraw() +32 63.73% 76.77%
framework/d/d_menu_fmap2D dMenu_Fmap2DBack_c::regionGridDraw() +24 75.02% 77.47%
framework/d/d_menu_fmap2D dMenu_Fmap2DBack_c::regionOriginDraw() +24 77.63% 87.80%

...and 6 more improvements in unmatched items


Report for RZDP01 (c8fa8c9 - 68a0a41)

📈 Matched code: 53.81% (+0.09%, +9492 bytes)
📈 Matched data: 55.66% (+0.01%, +288 bytes)

✅ 24 new matches
Unit Item Bytes Before After
framework/d/d_menu_fmap dMenu_Fmap_c::getNextStatus(unsigned char*) +370 18.19% 100.00%
framework/d/d_menu_dmap dMenu_DmapBg_c::setCButtonString(unsigned long) +152 0.63% 100.00%
framework/d/d_menu_map_common dMenuMapCommon_c::drawIcon(float, float, float, float) +143 91.14% 100.00%
framework/d/d_menu_fmap2D dMenu_Fmap2DBack_c::~dMenu_Fmap2DBack_c() +106 84.80% 100.00%
framework/d/d_map dMap_c::_move(float, float, int, float) +57 97.17% 100.00%
framework/d/d_menu_fmap dMenu_Fmap_c::_create() +41 97.82% 100.00%
framework/d/d_menu_map_common dMenuMapCommon_c::getMirrorCenterPosX(float, float) +40 0.00% 100.00%
framework/d/d_menu_fmap2D dMenu_Fmap2DTop_c::setAButtonString(unsigned long, unsigned char) +39 83.16% 100.00%
framework/d/d_menu_dmap dMenu_Dmap_c::floorChangeMode() +29 88.91% 100.00%
framework/d/d_menu_dmap dMenu_Dmap_c::zoomIn_proc() +28 83.33% 100.00%
framework/d/d_menu_dmap dMenu_Dmap_c::zoomOut_proc() +28 82.44% 100.00%
framework/d/d_menu_dmap dMenu_Dmap_c::isMapMoveState() +21 71.89% 100.00%
framework/d/d_menu_fmap2D dMenu_Fmap2DTop_c::draw() +21 93.47% 100.00%
framework/d/d_map_path dRenderingFDAmap_c::preRenderingMap() +10 97.80% 100.00%
framework/d/d_menu_dmap_map dMenu_StageMapCtrl_c::getTreasureList(float*, float*, signed char*, unsigned char*, signed char*) +9 97.47% 100.00%
framework/d/d_menu_fmap2D .sdata2 +9 90.91% 100.00%
framework/d/d_menu_fmap2D .sbss +8 0.00% 100.00%
framework/d/d_map .sdata2 +5 95.65% 100.00%
framework/d/d_map_path .sdata2 +5 85.71% 100.00%
framework/d/d_menu_dmap_map dMenu_StageMapCtrl_c::getPlayerDrawInfo(float*, float*, short*) const +5 96.91% 100.00%
framework/d/d_menu_dmap_map dMenu_StageMapCtrl_c::getRestartDrawInfo(float*, float*, short*) const +5 97.16% 100.00%
framework/d/d_menu_dmap_map dMenu_StageMapCtrl_c::cnvPosTo2Dpos(float, float, float*, float*) const +4 96.43% 100.00%
framework/d/d_map dMap_c::calcMapCmPerTexel(int, float*) +3 99.26% 100.00%
framework/d/d_menu_map_common .sdata2 +3 96.00% 100.00%
📈 37 improvements in unmatched items
Unit Item Bytes Before After
framework/d/d_menu_fmap2D dMenu_Fmap2DBack_c::allmap_move2(STControl*) +720 48.51% 94.39%
framework/d/d_menu_fmap2D dMenu_Fmap2DBack_c::regionMapMove(STControl*) +678 50.70% 94.37%
framework/d/d_menu_dmap dMenu_DmapBg_c::dpdMove(signed char, signed char, signed char, unsigned char*, unsigned char) +504 0.93% 84.87%
framework/d/d_menu_dmap dMenu_Dmap_c::_move() +391 42.14% 97.67%
framework/d/d_menu_fmap2D .data +352 17.72% 99.18%
framework/d/d_menu_fmap dMenu_Fmap_c::region_map_proc() +285 77.64% 95.54%
framework/d/d_menu_dmap dMenu_DmapBg_c::setJButtonString(unsigned long) +273 2.75% 98.80%
framework/d/d_menu_fmap dMenu_Fmap_c::spot_map_proc() +252 66.25% 82.64%
framework/d/d_menu_fmap2D dMenu_Fmap2DBack_c::draw() +221 80.11% 89.69%
framework/d/d_menu_dmap dMenu_DmapBg_c::baseScreenInit() +195 64.69% 87.61%
framework/d/d_menu_fmap2D dMenu_Fmap2DBack_c::regionTextureDraw() +167 62.14% 79.96%
framework/d/d_menu_fmap2D dMenu_Fmap2DBack_c::drawDebugStageArea() +150 69.38% 93.77%
framework/d/d_menu_fmap2D dMenu_Fmap2DBack_c::dMenu_Fmap2DBack_c() +129 86.96% 93.82%
framework/d/d_menu_fmap2D dMenu_Fmap2DTop_c::dMenu_Fmap2DTop_c(JKRExpHeap*, STControl*) +123 92.93% 98.95%
framework/d/d_menu_dmap dMenu_Dmap_c::screenInit() +117 97.02% 99.76%
framework/d/d_menu_fmap dMenu_Fmap_c::all_map_proc() +108 92.45% 99.23%
framework/d/d_menu_dmap dMenu_DmapBg_c::~dMenu_DmapBg_c() +107 90.33% 97.53%
framework/d/d_menu_dmap .rodata +96 70.65% 81.50%
framework/d/d_menu_fmap dMenu_Fmap_c::portalWarpMapMove(STControl*) +90 76.08% 93.93%
framework/d/d_menu_dmap dMenu_DmapBg_c::mapScreenInit() +88 87.24% 93.21%
framework/d/d_menu_dmap dMenu_DmapBg_c::draw() +62 86.21% 89.13%
framework/d/d_menu_fmap2D dMenu_Fmap2DBack_c::stageMapMove(STControl*, unsigned char, bool) +62 57.50% 60.53%
framework/d/d_menu_fmap dMenu_Fmap_c::drawPlayEnterIcon() +47 74.60% 92.62%
framework/d/d_menu_fmap dMenu_Fmap_c::drawIcon(float, bool) +46 84.72% 91.61%
framework/d/d_menu_fmap dMenu_Fmap_c::spot_map_init() +41 85.19% 97.81%
framework/d/d_menu_fmap2D dMenu_Fmap2DBack_c::scrollAreaDraw() +40 71.19% 78.31%
framework/d/d_menu_fmap2D dMenu_Fmap2DBack_c::worldGridDraw() +34 73.08% 76.65%
framework/d/d_map_path_dmap dMpath_c::setPointer(signed char, void*, int) +32 73.51% 83.04%
framework/d/d_menu_fmap2D dMenu_Fmap2DBack_c::worldOriginDraw() +32 63.73% 76.77%
framework/d/d_menu_fmap2D dMenu_Fmap2DBack_c::regionGridDraw() +24 75.02% 77.47%

...and 7 more improvements in unmatched items


Report for GZ2J01 (c8fa8c9 - 68a0a41)

No changes

Report for RZDE01_00 (c8fa8c9 - 68a0a41)

📈 Matched code: 47.12% (+0.06%, +6736 bytes)
📈 Matched data: 54.01% (+0.01%, +288 bytes)

✅ 21 new matches
Unit Item Bytes Before After
framework/d/d_menu_fmap dMenu_Fmap_c::getNextStatus(unsigned char*) +370 18.19% 100.00%
framework/d/d_menu_dmap dMenu_DmapBg_c::setCButtonString(unsigned long) +152 0.63% 100.00%
framework/d/d_menu_map_common dMenuMapCommon_c::drawIcon(float, float, float, float) +143 91.14% 100.00%
framework/d/d_map dMap_c::_move(float, float, int, float) +57 97.17% 100.00%
framework/d/d_menu_map_common dMenuMapCommon_c::getMirrorCenterPosX(float, float) +40 0.00% 100.00%
framework/d/d_menu_dmap dMenu_Dmap_c::floorChangeMode() +29 88.91% 100.00%
framework/d/d_menu_dmap dMenu_Dmap_c::zoomIn_proc() +28 83.33% 100.00%
framework/d/d_menu_dmap dMenu_Dmap_c::zoomOut_proc() +28 82.44% 100.00%
framework/d/d_menu_dmap dMenu_Dmap_c::isMapMoveState() +21 71.89% 100.00%
framework/d/d_menu_fmap2D dMenu_Fmap2DTop_c::draw() +21 93.47% 100.00%
framework/d/d_map_path dRenderingFDAmap_c::preRenderingMap() +10 97.80% 100.00%
framework/d/d_menu_dmap_map dMenu_StageMapCtrl_c::getTreasureList(float*, float*, signed char*, unsigned char*, signed char*) +9 97.47% 100.00%
framework/d/d_menu_fmap2D .sdata2 +9 90.91% 100.00%
framework/d/d_menu_fmap2D .sbss +8 0.00% 100.00%
framework/d/d_map .sdata2 +5 95.65% 100.00%
framework/d/d_map_path .sdata2 +5 85.71% 100.00%
framework/d/d_menu_dmap_map dMenu_StageMapCtrl_c::getPlayerDrawInfo(float*, float*, short*) const +5 96.91% 100.00%
framework/d/d_menu_dmap_map dMenu_StageMapCtrl_c::getRestartDrawInfo(float*, float*, short*) const +5 97.16% 100.00%
framework/d/d_menu_dmap_map dMenu_StageMapCtrl_c::cnvPosTo2Dpos(float, float, float*, float*) const +4 96.43% 100.00%
framework/d/d_map dMap_c::calcMapCmPerTexel(int, float*) +3 99.26% 100.00%
framework/d/d_menu_map_common .sdata2 +3 96.00% 100.00%
📈 40 improvements in unmatched items
Unit Item Bytes Before After
framework/d/d_menu_fmap2D dMenu_Fmap2DBack_c::allmap_move2(STControl*) +720 48.51% 94.39%
framework/d/d_menu_fmap2D dMenu_Fmap2DBack_c::regionMapMove(STControl*) +678 50.70% 94.37%
framework/d/d_menu_dmap dMenu_DmapBg_c::dpdMove(signed char, signed char, signed char, unsigned char*, unsigned char) +504 0.93% 84.87%
framework/d/d_menu_dmap dMenu_Dmap_c::_move() +391 42.14% 97.67%
framework/d/d_menu_fmap2D .data +352 17.72% 99.18%
framework/d/d_menu_fmap dMenu_Fmap_c::region_map_proc() +285 77.64% 95.54%
framework/d/d_menu_dmap dMenu_DmapBg_c::setJButtonString(unsigned long) +273 2.75% 98.80%
framework/d/d_menu_fmap dMenu_Fmap_c::spot_map_proc() +252 66.25% 82.64%
framework/d/d_menu_fmap2D dMenu_Fmap2DBack_c::draw() +222 80.10% 89.68%
framework/d/d_menu_dmap dMenu_DmapBg_c::baseScreenInit() +195 64.69% 87.61%
framework/d/d_menu_fmap2D dMenu_Fmap2DBack_c::regionTextureDraw() +167 62.14% 79.96%
framework/d/d_menu_fmap2D dMenu_Fmap2DBack_c::drawDebugStageArea() +150 69.38% 93.77%
framework/d/d_menu_fmap2D dMenu_Fmap2DBack_c::dMenu_Fmap2DBack_c() +124 84.80% 91.49%
framework/d/d_menu_dmap dMenu_Dmap_c::screenInit() +117 97.02% 99.76%
framework/d/d_menu_fmap dMenu_Fmap_c::all_map_proc() +108 92.45% 99.23%
framework/d/d_menu_dmap dMenu_DmapBg_c::~dMenu_DmapBg_c() +107 90.33% 97.53%
framework/d/d_menu_fmap2D dMenu_Fmap2DBack_c::~dMenu_Fmap2DBack_c() +106 81.65% 97.21%
framework/d/d_menu_fmap2D dMenu_Fmap2DTop_c::dMenu_Fmap2DTop_c(JKRExpHeap*, STControl*) +103 37.60% 39.90%
framework/d/d_menu_fmap dMenu_Fmap_c::portalWarpMapMove(STControl*) +90 76.08% 93.93%
framework/d/d_menu_dmap dMenu_DmapBg_c::mapScreenInit() +88 87.24% 93.21%
framework/d/d_menu_dmap .rodata +83 64.94% 75.13%
framework/d/d_menu_dmap dMenu_DmapBg_c::draw() +62 86.21% 89.13%
framework/d/d_menu_fmap2D dMenu_Fmap2DBack_c::stageMapMove(STControl*, unsigned char, bool) +62 58.42% 61.50%
framework/d/d_menu_fmap dMenu_Fmap_c::drawPlayEnterIcon() +47 74.60% 92.62%
framework/d/d_menu_fmap dMenu_Fmap_c::drawIcon(float, bool) +46 84.72% 91.61%
framework/d/d_menu_fmap dMenu_Fmap_c::spot_map_init() +41 85.19% 97.81%
framework/d/d_menu_fmap2D dMenu_Fmap2DBack_c::scrollAreaDraw() +39 71.04% 78.17%
framework/d/d_menu_fmap2D dMenu_Fmap2DTop_c::setAButtonString(unsigned long, unsigned char) +38 40.96% 50.47%
framework/d/d_menu_fmap dMenu_Fmap_c::_create() +35 84.62% 86.38%
framework/d/d_menu_fmap2D dMenu_Fmap2DBack_c::worldGridDraw() +34 72.96% 76.52%

...and 10 more improvements in unmatched items

Mostly dmap (there's still a lot missing here particularly in mapControl)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant