Skip to content

chore: CI worfklows for linting docs#4076

Open
maxrjones wants to merge 8 commits into
zarr-developers:mainfrom
maxrjones:chore/test-docs-formatting
Open

chore: CI worfklows for linting docs#4076
maxrjones wants to merge 8 commits into
zarr-developers:mainfrom
maxrjones:chore/test-docs-formatting

Conversation

@maxrjones

@maxrjones maxrjones commented Jun 17, 2026

Copy link
Copy Markdown
Member

This PR adds a few scripts/workflows to:

  • Check that all top-level functions are included in the mkdocs API documentation
  • Check that docstrings use mkdocs rather than sphinx styles admonitions and links
  • Check that all links resolve

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/user-guide/*.md
  • Changes documented as a new file in changes/
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@github-actions github-actions Bot added the needs release notes Automatically applied to PRs which haven't added release notes label Jun 17, 2026
@maxrjones maxrjones changed the title chore: CI worfklows for missing docs and RST docstrings chore: CI worfklows for linting docs Jun 17, 2026
@maxrjones

Copy link
Copy Markdown
Member Author

@d-v-b @chuckwondo this adds a fair amount of config/workflow files, so a review on the direction here would be welcome but not necessarily required

Comment thread ci/check_documented_exports.py Outdated
Comment thread ci/check_documented_exports.py Outdated
Comment thread ci/check_documented_exports.py Outdated
Comment thread ci/check_documented_exports.py Outdated
Comment thread ci/check_documented_exports.py Outdated
Comment thread ci/check_documented_exports.py Outdated
Comment thread ci/lint_docs.py Outdated
@maxrjones

Copy link
Copy Markdown
Member Author

thanks for the review @chuckwondo. I applied your fixes in fd36246 (this PR) and some other readability improvements. I chose to make the directory an optional argument.

@codecov

codecov Bot commented Jun 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.50%. Comparing base (fd6189b) to head (ce89d7f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4076   +/-   ##
=======================================
  Coverage   93.50%   93.50%           
=======================================
  Files          90       90           
  Lines       11979    11979           
=======================================
  Hits        11201    11201           
  Misses        778      778           
Files with missing lines Coverage Δ
src/zarr/core/metadata/v2.py 89.44% <ø> (ø)
src/zarr/testing/store.py 99.43% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@maxrjones maxrjones requested a review from chuckwondo June 25, 2026 13:24
@maxrjones maxrjones self-assigned this Jun 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs release notes Automatically applied to PRs which haven't added release notes tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants