Skip to content

chore: simplify contributor env setup - #403

Open
cameronapak wants to merge 1 commit into
mainfrom
ype-5843-root-env-setup
Open

cameronapak wants to merge 1 commit into
mainfrom
ype-5843-root-env-setup

Conversation

@cameronapak

@cameronapak cameronapak commented Sep 14, 2026

Copy link
Copy Markdown
Collaborator

Use one root .env across dev harnesses.

Preserve overrides; fix dev:web and Turbo inputs.

YPE-5843

Greptile Summary

This PR consolidates contributor configuration into a root .env, while preserving shell and harness-specific overrides.

  • Loads the shared configuration in core tests, the Vite example, and Storybook.
  • Repairs dev:web to run the Vite demo and its workspace dependencies.
  • Declares the root environment file and relevant variables as Turbo inputs.
  • Updates contributor documentation and adds an intentional empty changeset.

Confidence Score: 5/5

The PR appears safe to merge, with no concrete changed-code failure identified.

The environment loaders preserve shell and package-local precedence, the corrected Turbo filter follows the actual demo dependency graph, and the shared root configuration is represented in Turbo’s inputs.

Important Files Changed

Filename Overview
examples/vite-react/vite.config.ts Loads root and package-local environment values with explicit process-variable precedence and exposes browser-safe Vite-prefixed settings.
packages/ui/.storybook/main.ts Applies the shared root environment setup to Storybook while retaining package-local and process overrides.
packages/core/package.json Extends core test scripts to load the root environment after the optional package-local override.
package.json Replaces the obsolete development filter with the Vite example and its workspace dependency closure.
turbo.json Adds the root environment file and relevant variables to Turbo hashing and task environments.

Reviews (1): Last reviewed commit: "chore: simplify contributor env setup" | Re-trigger Greptile

Context used:

Use one optional root .env for the core tests, Storybook, and Vite demo while preserving package-local and CI overrides. Fix the dev:web target and Turbo environment invalidation.

YPE-5843

Amp-Thread-ID: https://ampcode.com/threads/T-01a0a15f-295c-71cf-a9a8-6b02a36cba15
@changeset-bot

changeset-bot Bot commented Sep 14, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: cf4fd7f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

Copy link
Copy Markdown
Contributor

🚨 Breaking change detected — signoff required for v

This PR adds a changeset declaring a major bump, which would ship all three packages as v (they are a fixed group in .changeset/config.json, so they version together). Merging is blocked until a repo collaborator with write access comments on this PR with all four (4) of the following:

  1. The verbatim acknowledgment phrase below,
  2. The precise next version (v or ``),
  3. The full commit hash being approved (cf4fd7fd46f7fcb15da425d0a086c1ddb26aeca9), and
  4. A 🚀 (:rocket:) emoji.

I confirm that this is an intentional breaking change, and I have read the release procedures. I understand and have documented its impact upon release.

Copy-paste-ready reply:

I confirm that this is an intentional breaking change, and I have read the release procedures. I understand and have documented its impact upon release.

v cf4fd7fd46f7fcb15da425d0a086c1ddb26aeca9 🚀

The check re-runs automatically when a qualifying comment is posted or edited. Pushing new commits changes the hash, so a fresh signoff is needed.

@cameronapak

Copy link
Copy Markdown
Collaborator Author

🚨 Breaking change detected — signoff required for v

This PR adds a changeset declaring a major bump, which would ship all three packages as v (they are a fixed group in .changeset/config.json, so they version together). Merging is blocked until a repo collaborator with write access comments on this PR with all four (4) of the following:

  1. The verbatim acknowledgment phrase below,
  2. The precise next version (v or ``),
  3. The full commit hash being approved (cf4fd7fd46f7fcb15da425d0a086c1ddb26aeca9), and
  4. A 🚀 (:rocket:) emoji.

I confirm that this is an intentional breaking change, and I have read the release procedures. I understand and have documented its impact upon release.

Copy-paste-ready reply:

I confirm that this is an intentional breaking change, and I have read the release procedures. I understand and have documented its impact upon release.

v cf4fd7fd46f7fcb15da425d0a086c1ddb26aeca9 🚀

The check re-runs automatically when a qualifying comment is posted or edited. Pushing new commits changes the hash, so a fresh signoff is needed.

question: Are empty change sets accounted for when it comes to this check?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants