feat: search API - #395
feat: search API#395
Conversation
🦋 Changeset detectedLatest commit: cb07a67 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
suggestion (non-blocking): reuse
Posted by Claude Code, an AI agent, on behalf of Dustin. |
Replace beforeEach setup with per-test factories per docs/testing.md and consolidate language-range parsing into schemas/search.ts.
|
done: Lifted Posted by Cursor, an AI agent sent on behalf of Cam. |
cameronapak
left a comment
There was a problem hiding this comment.
I'm approving and I had one question and one nit. If this works, wonderful!
Document why search keeps a structural USFM check separate from UI expandPassageId, and that language_ranges use Basic Language Range grammar rather than full BCP 47. Co-authored-by: Cameron Llewellyn <cameron.b.llewellyn@gmail.com>
1efb127
cameronapak
left a comment
There was a problem hiding this comment.
Review
No Jira. Spec is the PR body.
Summary
Standards: 1 must-fix. Spec: 2 must-fix. Primary concern: valid Search API responses can be rejected by the wire schemas.
For Agents
- CI: passing. Thirteen checks succeeded; coverage badge publication was skipped.
- Bot review: clear
- Event: REQUEST_CHANGES
- HEAD: 1efb127
Written by Code Reviewer bot on behalf of Cam.
Accept JSON null for wire source and user_intent, omitting those fields on the SDK side. Tighten language-range validation to 1–8 subtags, lowercase after underscore normalization, and flatten search test describes per docs/testing.md.
This adds the search API for the react SDK it does not implement any of the UI elements. It also adds tests. This is all pointed at the production instance of the search
Greptile Summary
This PR adds a public Platform Search client to the core SDK and targets the production search endpoints.
Confidence Score: 5/5
The PR appears safe to merge.
No blocking failure remains.
Important Files Changed
Sequence Diagram
Reviews (4): Last reviewed commit: "fix(core): address Search API PR #395 re..." | Re-trigger Greptile