MDB-42341: handle exception in pg_wal_replay_resume + fix race condition in cascade#158
Open
aak74 wants to merge 2 commits into
Open
MDB-42341: handle exception in pg_wal_replay_resume + fix race condition in cascade#158aak74 wants to merge 2 commits into
aak74 wants to merge 2 commits into
Conversation
aak74
changed the title
vicpopov
requested changes
May 5, 2026
| primary_unavailability_timeout: 2 | ||
| recovery_timeout: 30 | ||
| commands: | ||
| generate_recovery_conf: /usr/local/bin/gen_rec_conf_without_slot.sh %m %p |
Collaborator
There was a problem hiding this comment.
The problem with this scenario is actually here: recovery_conf generation command generates primary_conninfo without slots requirement, so replicas connect to master even before slots are created.
This ruins the scenario which otherwise would work.
Collaborator
Author
There was a problem hiding this comment.
Scenario assumes that slots will be created automatically. That is, the command looks like the right one.
Scenario Outline: Replication slots created automatically
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wrap WAL replay resume logic in try/except to prevent unhandled exceptions from crashing the iteration. On failure, a warning is logged with traceback and the operation is retried on next cycle.
Fix race condition in cascade.feature