This repository was archived by the owner on May 12, 2020. It is now read-only.
Add a shutdown hook to delete extracted files - #141
Open
footaku wants to merge 5 commits into
Open
Conversation
postgresql-embedded leave directory in temporary space. This is because of sequence sometimes does not called when process is killed. So, I want to add a cleaner to shutdown hook.
smecsia
reviewed
Oct 19, 2018
smecsia
left a comment
smecsia
left a comment
Member
There was a problem hiding this comment.
My feeling is that when you cannot avoid Powermock usage, it's kind of an issue.
Author
|
Thank you for your confirmation. I try to solve. |
|
Is this ticket due to be merged? @smecsia we are having issues with this and it looks like there is no merge in sight |
|
+1 here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried to fix #113