feat: byte length fill on sf writing#57
Open
joseluisballesterosdelval wants to merge 3 commits into
Open
Conversation
moritzfl
added a commit
to moritzfl/afplib
that referenced
this pull request
Jun 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a structured field is written, it may be useful to know the number of written bytes. For example, if I wanted to read an AFP, insert some marks (such as NOPs), and write the result in another file, and if I saved the positions of these marks, I would need to know the byte offset introduced by these marks (NOPs in this example), in order to know the actual position of write cursor.
In this pull request, along with some chore operations (.gitignore additions), it goes a minimal change in AfpOutputStream class, which enables described functionality.