Skip to content

Add RestResponse::ok() #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thekid merged 1 commit into from
Feb 22, 2026
Merged

Add RestResponse::ok() #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/main/php/webservices/rest/RestResponse.class.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,9 @@ public function __construct($status, $message, $headers= [], $reader= null, $uri
/** @return int */
public function status() { return $this->status; }

/** @return bool */
public function ok() { return $this->status >= 200 && $this->status <= 299; }

/** @return string */
public function message() { return $this->message; }

Expand Down
5 changes: 5 additions & 0 deletions src/test/php/webservices/rest/unittest/RestResponseTest.class.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,11 @@ public function status() {
Assert::equals(200, (new RestResponse(200, 'OK'))->status());
}

#[Test, Values([[200, true], [202, true], [299, true], [100, false], [300, false], [400, false]])]
public function ok($status, $expected) {
Assert::equals($expected, (new RestResponse($status, 'Status #'.$status))->ok());
}

#[Test]
public function message() {
Assert::equals('OK', (new RestResponse(200, 'OK'))->message());
Expand Down
Loading