refactor: centralize test utilities and standardize test patterns#99
Merged
Conversation
This was referenced Apr 5, 2026
Collaborator
Author
4 tasks
ApprovabilityA prior Macroscope approval was dismissed. Re-evaluating bf652cf… No code changes detected at |
Collaborator
Author
Merge activity
|
Dismissing prior approval to re-evaluate bf652cf
- Move test/helpers.go to pkg/testutils/db.go
- Add pkg/testutils/logger.go with TestLogger(t) using zaptest
- Replace logging.CreateLogger("console", "info") with testutils.TestLogger(t)
- Replace context.Background() with t.Context() in all test files
- Standardize t.Cleanup in api_test.go (remove defer ctx.cleanup pattern)
- Standardize require over assert in http_test.go
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
bf652cf to
0de1f5f
Compare
mkysel
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com
Note
Centralize test utilities and standardize test patterns across packages
test/helpers.goto pkg/testutils/db.go and adds a newTestLoggerhelper in pkg/testutils/logger.go to provide a standardized, test-bound zap logger.context.Background()witht.Context()and switches fromasserttorequirein tests acrossapi,db,delivery,installations,subscriptions, andxmtppackages.Macroscope summarized bf652cf.