Skip to content

Skip verify after sector erase to prevent 5ms delay causing clock stretching on I2C hosts #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ed-xmos wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

Skip verify after sector erase to prevent 5ms delay causing clock stretching on I2C hosts #45

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions lib_dfu/src/dfu.xc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,8 +200,10 @@ static enum dfu_status getstatus_from_dnload(bool &busy)

case DNLOAD_ERASING_SECTOR:
if (!flash_is_busy()) {
if (!flash_is_sector_erased(dnload.next_page_address))
return ERR_CHECK_ERASED;
// See https://github.com/xmos/lib_dfu/issues/44
// This works around a problem seen where I2C clock stretching for 5ms breaks the DFU process
// if (!flash_is_sector_erased(dnload.next_page_address))
// return ERR_CHECK_ERASED;

if (!is_address_in_an_upgrade_slot(dnload.next_page_address))
return ERR_ADDRESS;
Expand Down