Fix django parallel test runner's elapsed time reporting on python 3.12 or higher#297
Open
dhruvparanjape wants to merge 2 commits into
Open
Conversation
Author
dhruvparanjape
force-pushed
the
fix_django_parallel_test_runner_reporting
branch
from
2fbe137 to
beaeac1
Compare
For test runners with python 3.12 or higher we should use `collectedDurations` to calculate the elapsed time. In parallel test runners the start/stopTest events are processed in the parent process which means they don't actually execute the test i.e. the test time is missing from our calculations. Using collectedDurations we can calculate the test time correctly.
dhruvparanjape
force-pushed
the
fix_django_parallel_test_runner_reporting
branch
from
beaeac1 to
31aa68f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For test runners with python 3.12 or higher we should use
collectedDurationsto calculate the elapsed time.In parallel test runners the start/stopTest events are processed in the parent process which means they don't actually execute the test i.e. the test time is missing from our calculations. Using collectedDurations we can calculate the test time correctly.
Also added elapsed time checking so all tests now validate the elapsed time to prevent any regressions.