Cap k3d create_cluster retries at three attempts - #421
Open
SebTardif wants to merge 1 commit into
Open
Conversation
create_cluster deleted and retried forever when k3d create kept failing. Stop after three attempts, matching delete_cluster. Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stop unbounded retries in
k3d.create_cluster.Problem
K3D.create_clusterretries forever whenk3d cluster createkeeps failing:Kind already aborts after a few create failures. #419 caps
delete_cluster. If delete succeeds and create still fails (bad image, docker error), this loop never exits.Change
Raise
RuntimeError("Failed to create k3d cluster")after three create attempts (two delete-and-retry cycles). No other k3d formatting.Validation
pytest acto/kubernetes_engine/test_k3d_create.pyOrigin
The loop has been in
153ef757/ #155 (2022-08-05, Yuxuan).Ref #413
Ref #419