Conversation
scripts/process_bugs_info.py no longer embeds a Jira API token. Pass --jira-token or set JIRA_TOKEN. Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Load the Jira API token from
--jira-tokenorJIRA_TOKENinstead of a hardcoded value.Problem
scripts/process_bugs_info.pyis a research helper that talks to Percona Jira. It constructedJIRA(..., token_auth=...)with a token baked into the source. Anyone with a clone of this repo can read that value from currentmainand from git history.Private vulnerability reporting is not enabled on this repository, so this change is a public cleanup. Please rotate the old Jira token even if the script is unused.
Change
--jira-tokenor theJIRA_TOKENenvironment variable.if __name__ == "__main__"so the helper can be imported in tests.The token value is not repeated here.
Validation
pytest acto/utils/test_process_bugs_info.pytoken_auth='...'still present).token_authliteral; CLI wins over env; missing token raisesSystemExit.Origin
The hardcoded
token_authhas been inbdaf5662(2023-02-03, Tyler Gu) and later commits.