Skip to content

Remove Cosmetica from legacy defaults and documented load lists - #391

Merged
xfl03 merged 2 commits into
15-developfrom
copilot/find-and-remove-cosmetica
Aug 12, 2026
Merged

xfl03 merged 2 commits into
15-developfrom
copilot/find-and-remove-cosmetica

Conversation

Copilot AI commented Aug 11, 2026 •

Copy link
Copy Markdown
Contributor

This change removes Cosmetica from the repository’s default cape provider set and aligns documentation with runtime behavior. The default list now excludes Cosmetica in both code and README references.

  • Runtime default profile changes

    • Removed the Cosmetica legacy cape profile entry from LegacyLoader#getDefaultProfiles().
    • Preserved existing provider ordering and priorities for remaining entries.
  • Documentation alignment

    • Removed Cosmetica from:
      • “Supported special skin sites and profiles”
      • “Default Load List”
    • Keeps README consistent with shipped defaults.
  • Code example (updated default legacy entries)

    return Lists.newArrayList(new LocalSkin(this),
            getCapeProfile(this, "OptiFine", "https://optifine.net/capes/{USERNAME}.png", 810),
            getCapeProfile(this, "CloakPlus", "http://161.35.130.99/capes/{USERNAME}.png", 840)
            //getCapeProfile(this, "LabyMod", "https://dl.labymod.net/capes/{STANDARD_UUID}", 850)
    );

Co-authored-by: xfl03 <3205159+xfl03@users.noreply.github.com>
Copilot AI changed the title Remove Cosmetica support from default list Remove Cosmetica from legacy defaults and documented load lists Aug 11, 2026
Copilot AI requested a review from xfl03 August 11, 2026 13:51
@xfl03
xfl03 marked this pull request as ready for review August 11, 2026 13:52
Copilot AI lite review requested due to automatic review settings August 11, 2026 13:52

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the Cosmetica legacy cape provider from MCCustomSkinLoader’s shipped legacy default profile list and updates README sections so the documented supported/default provider lists match the runtime defaults.

Changes:

  • Removed the Cosmetica entry from LegacyLoader#getDefaultProfiles() legacy default profiles.
  • Removed Cosmetica references from README “Supported special skin sites and profiles” and “Default Load List”.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
README.md Removes Cosmetica from documented supported/default provider lists to match runtime defaults.
Common/src/main/java/customskinloader/loader/LegacyLoader.java Removes Cosmetica from legacy default profiles while preserving remaining ordering/priorities.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@xfl03
xfl03 requested review from ZekerZhayard and a lite review from Copilot August 12, 2026 12:05

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Suppressed comments (1)

Common/src/main/java/customskinloader/loader/LegacyLoader.java:32

  • The commented-out LabyMod entry can no longer be enabled by simply uncommenting it because CloakPlus is now the last argument (no trailing comma). If you want to keep this as an optional entry, rewrite it so the separating comma lives inside the comment block, so toggling it won’t require additional edits.
                getCapeProfile(this, "CloakPlus", "http://161.35.130.99/capes/{USERNAME}.png", 840)
                //getCapeProfile(this, "LabyMod", "https://dl.labymod.net/capes/{STANDARD_UUID}", 850)
                );

Co-authored-by: xfl03 <3205159+xfl03@users.noreply.github.com>
@xfl03

xfl03 commented Aug 12, 2026

Copy link
Copy Markdown
Owner

#379

@xfl03
xfl03 merged commit f334a61 into 15-develop Aug 12, 2026
1 check passed
@xfl03
xfl03 deleted the copilot/find-and-remove-cosmetica branch August 12, 2026 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants