tests: make test server robust when portpicker is unavailable#125
Open
shuofengzhang wants to merge 2 commits into
Open
tests: make test server robust when portpicker is unavailable#125shuofengzhang wants to merge 2 commits into
shuofengzhang wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
_pick_unused_port()helper intests/server.py.portpicker.pick_unused_port()whenportpickeris installed.portpickeris not installed.portpicker.pick_unused_port()calls in test server setup/context managers with_pick_unused_port().import portpickerin a safe optional import (ModuleNotFoundErrorfallback) for test-only robustness.Why
devdependency group (for example plainpip+pytest), test collection fails early with:ModuleNotFoundError: No module named 'portpicker'Insight / Why this matters
tests/server.pyhad an unconditionalportpickerimport, butportpickeris only guaranteed through a dev dependency group workflow.uv sync --dev, so the hidden hard dependency does not surface.Practical gain / Why this matters
Testing
scripts/clone_and_test.sh xai-org/xai-sdk-pythonModuleNotFoundError: No module named 'portpicker'.source .venv/bin/activate && pytest -q509 passed, 20 warnings.Risk analysis
tests/server.py), no runtime SDK API behavior changes.