Skip to content

Fix child theme activation failure on subsequent runs with different slug and name #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
swissspidy merged 9 commits into from
Feb 16, 2026
Merged

Fix child theme activation failure on subsequent runs with different slug and name #369

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
5cbbab2
Initial plan
Copilot Feb 2, 2026
6a7e45e
Fix theme activation when slug and name differ by refreshing theme cache
Copilot Feb 2, 2026
bef9b61
Refactor theme cache refresh into dedicated method with improved docs
Copilot Feb 2, 2026
eb06c25
Apply suggestion from @swissspidy
swissspidy Feb 4, 2026
ca7d210
Add wp_cache_delete to clear theme object cache
Copilot Feb 4, 2026
dbdf48f
Add clearstatcache() to refresh PHP filesystem cache
Copilot Feb 4, 2026
5835b9a
Clear individual theme caches to prevent stale WP_Theme objects
Copilot Feb 16, 2026
8e52a63
Merge branch 'main' into copilot/fix-theme-activate-issue
swissspidy Feb 16, 2026
80c8473
Simply use `WP_Theme::cache_delete`
swissspidy Feb 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 38 additions & 0 deletions features/scaffold.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,44 @@ Feature: WordPress code scaffolding
Success: Network enabled the 'Zombieland' theme.
"""

Scenario: Scaffold a child theme and activate it with different slug and name
Given a WP install

When I run `wp theme install twentytwentyone --force`
Then STDOUT should not be empty

And I run `wp theme path`
And save STDOUT as {THEME_DIR}

When I run `wp scaffold child-theme first-run --parent_theme=twentytwentyone --theme_name="First Run Name" --activate`
Then STDOUT should contain:
"""
Success: Created '{THEME_DIR}/first-run'.
"""
And STDOUT should contain:
"""
Success: Switched to 'First Run Name' theme.
"""

When I run `wp theme list --fields=name,status --format=csv`
Then STDOUT should contain:
"""
first-run,active
"""

# Now delete the theme and create it again to test the fix for the caching issue
When I run `rm -rf {THEME_DIR}/first-run`
And I run `wp theme activate twentytwentyone`
And I run `wp scaffold child-theme first-run --parent_theme=twentytwentyone --theme_name="First Run Name" --activate`
Then STDOUT should contain:
"""
Success: Created '{THEME_DIR}/first-run'.
"""
And STDOUT should contain:
"""
Success: Switched to 'First Run Name' theme.
"""

Scenario: Scaffold a child theme with invalid slug
Given a WP install
When I try `wp scaffold child-theme . --parent_theme=simple-life`
Expand Down
2 changes: 2 additions & 0 deletions src/Scaffold_Command.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -539,8 +539,10 @@ public function child_theme( $args, $assoc_args ) {
$this->log_whether_files_written( $files_written, $skip_message, $success_message );

if ( Utils\get_flag_value( $assoc_args, 'activate' ) ) {
wp_get_theme( $theme_slug )->cache_delete();
WP_CLI::run_command( [ 'theme', 'activate', $theme_slug ] );
} elseif ( Utils\get_flag_value( $assoc_args, 'enable-network' ) ) {
wp_get_theme( $theme_slug )->cache_delete();
WP_CLI::run_command( [ 'theme', 'enable', $theme_slug ], [ 'network' => true ] );
}
}
Expand Down